Changeset 67531 in webkit

Timestamp:

Sep 14, 2010 8:37:14 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-09-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Zoom factor for checkboxes and radios.
​https://bugs.webkit.org/show_bug.cgi?id=45776

RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of
checkboxes and radios.

Even with this change the used QStyle must support different sizes for radios and checkboxes.
QWindowStyle and QMacStyle, for example, do not.

• platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/qt/RenderThemeQt.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-14  Luiz Agostini  <luiz.agostini@openbossa.org>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] Zoom factor for checkboxes and radios.
+        https://bugs.webkit.org/show_bug.cgi?id=45776
+
+        RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of
+        checkboxes and radios.
+
+        Even with this change the used QStyle must support different sizes for radios and checkboxes.
+        QWindowStyle and QMacStyle, for example, do not.
+
+        * platform/qt/RenderThemeQt.cpp:
+        (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
+
 2010-09-14  Chris Rogers  <crogers@google.com>
 

trunk/WebCore/platform/qt/RenderThemeQt.cpp

@@ -381 +381 @@
         styleOption.state |= QStyle::State_Small;
         int checkBoxWidth = style->pixelMetric(QStyle::PM_IndicatorWidth, &styleOption);
+        checkBoxWidth *= renderStyle->effectiveZoom();
         size = QSize(checkBoxWidth, checkBoxWidth);
         break;
@@ -388 +389 @@
         styleOption.state |= QStyle::State_Small;
         int radioWidth = style->pixelMetric(QStyle::PM_ExclusiveIndicatorWidth, &styleOption);
+        radioWidth *= renderStyle->effectiveZoom();
         size = QSize(radioWidth, radioWidth);
         break;