Changeset 67675 in webkit

Timestamp:

Sep 16, 2010 3:35:30 PM (14 years ago)

Author:

andreas.kling@nokia.com

Message:

2010-09-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
​https://bugs.webkit.org/show_bug.cgi?id=45923

QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
instead of QPainter::clipPath().isEmpty().

• platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/TransparencyLayer.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-16  Andreas Kling  <andreas.kling@nokia.com>
+
+        Reviewed by Ariya Hidayat.
+
+        [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
+        https://bugs.webkit.org/show_bug.cgi?id=45923
+
+        QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
+        instead of QPainter::clipPath().isEmpty().
+
+        * platform/graphics/qt/TransparencyLayer.h:
+        (WebCore::TransparencyLayer::TransparencyLayer):
+
 2010-09-16  David Hyatt  <hyatt@apple.com>
 

trunk/WebCore/platform/graphics/qt/TransparencyLayer.h

@@ -62 +62 @@
         if (painter.paintEngine()->hasFeature(QPaintEngine::PorterDuff))
             painter.setCompositionMode(p->compositionMode());
-        // if the path is an empty region, this assignment disables all painting
-        if (!p->clipPath().isEmpty())
+        if (p->hasClipping())
             painter.setClipPath(p->clipPath());
     }