Changeset 67722 in webkit

Timestamp:

Sep 17, 2010 10:20:13 AM (14 years ago)

Author:

Martin Robinson

Message:

2010-09-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

Style bot complains about cairo forward declaration naming
​https://bugs.webkit.org/show_bug.cgi?id=45867

Exclude Cairo forward declarations from indentifiers with underscores checks.

• Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
• Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp.py (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-09-17  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Oliver Hunt.
+
+        Style bot complains about cairo forward declaration naming
+        https://bugs.webkit.org/show_bug.cgi?id=45867
+
+        Exclude Cairo forward declarations from indentifiers with underscores checks.
+
+        * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
+        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
+
 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
 

trunk/WebKitTools/Scripts/webkitpy/style/checkers/cpp.py

@@ -2520 +2520 @@
                 and not modified_identifier.startswith('NP_')
                 and not modified_identifier.startswith('qt_')
+                and not modified_identifier.startswith('cairo_')
                 and not modified_identifier.find('::qt_') >= 0
                 and not modified_identifier == "const_iterator"):

trunk/WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py

@@ -3704 +3704 @@
         self.assert_lint('void qt_drt_is_awesome(int var1, int var2);', '')
 
+        # Cairo forward-declarations should not be a failure.
+        self.assert_lint('typedef struct _cairo cairo_t;', '')
+        self.assert_lint('typedef struct _cairo_surface cairo_surface_t;', '')
+        self.assert_lint('typedef struct _cairo_scaled_font cairo_scaled_font_t;', '')
+
         # NPAPI functions that start with NPN_, NPP_ or NP_ are allowed.
         self.assert_lint('void NPN_Status(NPP, const char*)', '')