Changeset 68188 in webkit


Ignore:
Timestamp:
Sep 23, 2010 1:35:30 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

Since the setInterval call is meant to reflect a global change for
all pages' DOMTimers, it's misleading to have it be a method on a
given page's settings' object. Thus, this patch changes the call to be static.

This simple change to using a static call instead of the page's setting's
method doesn't warrant a test.

  • page/Settings.h: Changed the setInterval call to be static.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView/WebView.mm: Updating set interval call to use Settings' static version inside one time init block.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView.cpp: Updating set interval call to use Settings' static version inside one time init block.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebProcess/WebPage/WebPage.cpp: Updating set interval call to use Settings' static version.
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r68186 r68188  
     12010-09-23  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Reduce minimum DOMTimer interval
     6        https://bugs.webkit.org/show_bug.cgi?id=45362
     7
     8        Since the setInterval call is meant to reflect a global change for
     9        all pages' DOMTimers, it's misleading to have it be a method on a
     10        given page's settings' object. Thus, this patch changes the call to be static.
     11
     12        This simple change to using a static call instead of the page's setting's
     13        method doesn't warrant a test.
     14
     15        * page/Settings.h: Changed the setInterval call to be static.
     16
    1172010-09-23  David Hyatt  <hyatt@apple.com>
    218
  • trunk/WebCore/page/Settings.h

    r68166 r68188  
    201201        bool isDOMPasteAllowed() const { return m_isDOMPasteAllowed; }
    202202       
    203         void setMinDOMTimerInterval(double); // Interval specified in seconds.
     203        static void setMinDOMTimerInterval(double); // Interval specified in seconds.
    204204       
    205205        void setUsesPageCache(bool);
  • trunk/WebKit/mac/ChangeLog

    r68175 r68188  
     12010-09-23  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Reduce minimum DOMTimer interval
     6        https://bugs.webkit.org/show_bug.cgi?id=45362
     7
     8        * WebView/WebView.mm:
     9        Updating set interval call to use Settings' static version inside
     10        one time init block.
     11
    1122010-09-22  Andy Estes  <aestes@apple.com>
    213
  • trunk/WebKit/mac/WebView/WebView.mm

    r68175 r68188  
    696696        // Initialize our platform strategies.
    697697        WebPlatformStrategies::initialize();
     698        Settings::setMinDOMTimerInterval(0.004);
    698699
    699700        didOneTimeInitialization = true;
     
    717718    _private->page->setCanStartMedia([self window]);
    718719    _private->page->settings()->setLocalStorageDatabasePath([[self preferences] _localStorageDatabasePath]);
    719     _private->page->settings()->setMinDOMTimerInterval(0.004);
    720720
    721721    [WebFrame _createMainFrameWithPage:_private->page frameName:frameName frameView:frameView];
  • trunk/WebKit/win/ChangeLog

    r68179 r68188  
     12010-09-23  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Reduce minimum DOMTimer interval
     6        https://bugs.webkit.org/show_bug.cgi?id=45362
     7
     8        * WebView.cpp:
     9        Updating set interval call to use Settings' static version inside
     10        one time init block.
     11
    1122010-09-23  Nate Chapin  <japhet@chromium.org>
    213
  • trunk/WebKit/win/WebView.cpp

    r68179 r68188  
    25702570        WebKitSetApplicationCachePathIfNecessary();
    25712571        WebPlatformStrategies::initialize();
     2572        Settings::setMinDOMTimerInterval(0.004);
    25722573
    25732574        didOneTimeInitialization = true;
     
    25952596#endif
    25962597    m_page = new Page(pageClients);
    2597     m_page->settings()->setMinDOMTimerInterval(0.004);
    25982598
    25992599    BSTR localStoragePath;
  • trunk/WebKit2/ChangeLog

    r68182 r68188  
     12010-09-23  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Reduce minimum DOMTimer interval
     6        https://bugs.webkit.org/show_bug.cgi?id=45362
     7
     8        * WebProcess/WebPage/WebPage.cpp:
     9        Updating set interval call to use Settings' static version.
     10
    1112010-09-23  Adam Roben  <aroben@apple.com>
    212
  • trunk/WebKit2/WebProcess/WebPage/WebPage.cpp

    r68079 r68188  
    124124    m_page->settings()->setSerifFontFamily(store.serifFontFamily);
    125125    m_page->settings()->setJavaScriptCanOpenWindowsAutomatically(true);
    126     m_page->settings()->setMinDOMTimerInterval(0.004);
    127126
    128127    m_page->setGroupName("WebKit2Group");
    129128   
    130129    platformInitialize();
     130    Settings::setMinDOMTimerInterval(0.004);
    131131
    132132    m_mainFrame = WebFrame::createMainFrame(this);
Note: See TracChangeset for help on using the changeset viewer.