Changeset 68345 in webkit


Ignore:
Timestamp:
Sep 26, 2010 12:00:45 PM (14 years ago)
Author:
tonikitoo@webkit.org
Message:

document.nodesFromRect() needs to be removed from Document.idl
​https://bugs.webkit.org/show_bug.cgi?id=46492

Reviewed by Kenneth Christiansen and Andreas Kling.
Patch by Antonio Gomes <​agomes@rim.com>

WebCore:

As discussed with Sam Weinig on IRC, it was decided to removed
nodesFromRect() from the Document.idl, and that way, not exposing
it to Web content.

Reason: there is no plan to make it standard at the moment, and at the
very least, the method should had been originally added with the "webkit"
prefix, which was not the case.

  • dom/Document.idl:

LayoutTests:

Skip the tests relying on document.nodesFromRect in all platform for
the moment, and adjusting the expected results tests also accordingly.

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/Skipped:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r68344 r68345  
     12010-09-25  Antonio Gomes  <agomes@rim.com>
     2
     3        Reviewed by Kenneth Christiansen and Andreas Kling.
     4
     5        document.nodesFromRect() needs to be removed from Document.idl
     6        https://bugs.webkit.org/show_bug.cgi?id=46492
     7
     8        Skip the tests relying on document.nodesFromRect in all platform for
     9        the moment, and adjusting the expected results tests also accordingly.
     10
     11        * fast/dom/Window/window-properties-expected.txt:
     12        * platform/gtk/Skipped:
     13        * platform/mac/Skipped:
     14        * platform/qt/Skipped:
     15        * platform/qt/fast/dom/Window/window-properties-expected.txt:
     16        * platform/win/Skipped:
     17
    1182010-09-26  Renata Hodovan  <reni@inf.u-szeged.hu>
    219

  • trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

    r67898 r68345  
    627627window.Document.prototype.lookupNamespaceURI [function]
    628628window.Document.prototype.lookupPrefix [function]
    629 window.Document.prototype.nodesFromRect [function]
    630629window.Document.prototype.normalize [function]
    631630window.Document.prototype.queryCommandEnabled [function]

  • trunk/LayoutTests/platform/gtk/Skipped

    r68275 r68345  
    59295929# FileSystem API is not supported.
    59305930fast/filesystem
     5931
     5932# LayoutTestController::nodesFromRect is not supported.
     5933fast/dom/nodesFromRect-basic.html

  • trunk/LayoutTests/platform/mac/Skipped

    r68105 r68345  
    318318# FileSystem API is not supported.
    319319fast/filesystem
     320
     321# LayoutTestController::nodesFromRect is not supported.
     322fast/dom/nodesFromRect-basic.html

  • trunk/LayoutTests/platform/qt/Skipped

    r68341 r68345  
    54785478# FileSystem API is not supported.
    54795479fast/filesystem
     5480
     5481# LayoutTestController::nodesFromRect is not supported.
     5482fast/dom/nodesFromRect-basic.html

  • trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt

    r67907 r68345  
    625625window.Document.prototype.lookupNamespaceURI [function]
    626626window.Document.prototype.lookupPrefix [function]
    627 window.Document.prototype.nodesFromRect [function]
    628627window.Document.prototype.normalize [function]
    629628window.Document.prototype.queryCommandEnabled [function]

  • trunk/LayoutTests/platform/win/Skipped

    r68275 r68345  
    10041004# FileSystem API is not supported.
    10051005fast/filesystem
     1006
     1007# LayoutTestController::nodesFromRect is not supported.
     1008fast/dom/nodesFromRect-basic.html

  • trunk/WebCore/ChangeLog

    r68344 r68345  
     12010-09-25  Antonio Gomes  <agomes@rim.com>
     2
     3        Reviewed by Kenneth Christiansen and Andreas Kling.
     4
     5        document.nodesFromRect() needs to be removed from Document.idl
     6        https://bugs.webkit.org/show_bug.cgi?id=46492
     7
     8        As discussed with Sam Weinig on IRC, it was decided to removed
     9        nodesFromRect() from the Document.idl, and that way, not exposing
     10        it to Web content.
     11
     12        Reason: there is no plan to make it standard at the moment, and at the
     13        very least, the method should had been originally added with the "webkit"
     14        prefix, which was not the case.
     15
     16        * dom/Document.idl:
     17
    1182010-09-26  Renata Hodovan  <reni@inf.u-szeged.hu>
    219

  • trunk/WebCore/dom/Document.idl

    r67512 r68345  
    187187        readonly attribute [ConvertNullStringTo=Undefined] DOMString readyState;
    188188
    189 
    190         NodeList           nodesFromRect(in long x, in long y,
    191                                          in unsigned long hPadding,
    192                                          in unsigned long vPadding,
    193                                          in boolean ignoreClipping);
    194189        Element            elementFromPoint(in long x, in long y);
    195190        Range              caretRangeFromPoint(in long x, in long y);
Note: See TracChangeset for help on using the changeset viewer.