Changeset 68381 in webkit

Timestamp:

Sep 27, 2010 4:45:31 AM (14 years ago)

Author:

andreas.kling@nokia.com

Message:

2010-09-27 Andreas Kling <​andreas.kling@nokia.com>

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] 32-bit Flash crashes on repeated SetWindow calls
​https://bugs.webkit.org/show_bug.cgi?id=46616

Re-enable PluginQuirkDontCallSetWindowMoreThanOnce for Qt on x86 Unix.

We incorrectly thought this was fixed in Flash 10, but it turns out it
was just never broken on 64-bit.

• plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/PluginPackage.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-09-27  Andreas Kling  <andreas.kling@nokia.com>
+
+        Rubber-stamped by Kenneth Rohde Christiansen.
+
+        [Qt] 32-bit Flash crashes on repeated SetWindow calls
+        https://bugs.webkit.org/show_bug.cgi?id=46616
+
+        Re-enable PluginQuirkDontCallSetWindowMoreThanOnce for Qt on x86 Unix.
+
+        We incorrectly thought this was fixed in Flash 10, but it turns out it
+        was just never broken on 64-bit.
+
+        * plugins/PluginPackage.cpp:
+        (WebCore::PluginPackage::determineQuirks):
+
 2010-09-27  İsmail Dönmez  <ismail@namtrac.org>
 

trunk/WebCore/plugins/PluginPackage.cpp

@@ -205 +205 @@
             // Flash 9 and older requests windowless plugins if we return a mozilla user agent
             m_quirks.add(PluginQuirkWantsMozillaUserAgent);
-#if PLATFORM(QT)
-            // Flash 9 and older would crash on repeated calls to SetWindow in windowed mode
-            m_quirks.add(PluginQuirkDontCallSetWindowMoreThanOnce);
-#endif
         }
+
+#if PLATFORM(QT) && CPU(X86)
+        // 32-bit Flash will crash on repeated calls to SetWindow in windowed mode
+        m_quirks.add(PluginQuirkDontCallSetWindowMoreThanOnce);
+#endif
 
         m_quirks.add(PluginQuirkRequiresDefaultScreenDepth);