Changeset 68760 in webkit

Timestamp:

Sep 30, 2010 12:10:01 AM (14 years ago)

Author:

benjamin.poulain@nokia.com

Message:

2010-09-30 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix tst_QWebPage::geolocationRequestJS()
​https://bugs.webkit.org/show_bug.cgi?id=46814

Disable the test. This test cannot pass with a
standard build of WebKit, it is disabled until the API is finilized.

• tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• tests/qwebpage/tst_qwebpage.cpp (modified) (1 diff)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-09-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] Fix tst_QWebPage::geolocationRequestJS()
+        https://bugs.webkit.org/show_bug.cgi?id=46814
+
+        Disable the test. This test cannot pass with a
+        standard build of WebKit, it is disabled until the API is finilized.
+
+        * tests/qwebpage/tst_qwebpage.cpp:
+        (tst_QWebPage::geolocationRequestJS):
+
 2010-09-29  Andreas Kling  <andreas.kling@nokia.com>
 

trunk/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

@@ -248 +248 @@
 void tst_QWebPage::geolocationRequestJS()
 {
+    /*
+      This test is disabled because it can only succeed if ENABLE(GEOLOCATION) is true.
+      The code needs to be updated when the API of requestPermissionFromUser is updated.
+    */
+    QSKIP("Test disabled as long as geolocation is disabled from the build.", SkipSingle);
+
     JSTestPage* newPage = new JSTestPage(m_view);
     connect(newPage, SIGNAL(requestPermissionFromUser(QWebFrame*, QWebPage::PermissionDomain)),