Changeset 68902 in webkit

Timestamp:

Oct 1, 2010 11:11:24 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection shouldn't prompt the same correction after user has edited previous correction.
​https://bugs.webkit.org/show_bug.cgi?id=46839
<rdar://problem/8476963>

• editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Remove "CorrectionIndicator" marker instead of "Replacement" marker. Since the former controls whether we draw autocorrection underline, and the latter is used to prevent autocorrection from being applied again on already auto- corrected word. So the "Replacement" shouldn't be removed.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/Editor.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-01  Jia Pu  <jpu@apple.com>
+
+        Reviewed by Darin Adler.
+
+        Autocorrection shouldn't prompt the same correction after user has edited previous correction.
+        https://bugs.webkit.org/show_bug.cgi?id=46839
+        <rdar://problem/8476963>
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::respondToChangedSelection): Remove "CorrectionIndicator" marker instead of
+          "Replacement" marker. Since the former controls whether we draw autocorrection underline,
+          and the latter is used to prevent autocorrection from being applied again on already auto-
+          corrected word. So the "Replacement" shouldn't be removed.
+
 2010-10-01  Patrick Gansterer  <paroga@webkit.org>
 

trunk/WebCore/editing/Editor.cpp

@@ -3601 +3601 @@
         if (RefPtr<Range> wordRange = newAdjacentWords.toNormalizedRange()) {
             m_frame->document()->markers()->removeMarkers(wordRange.get(), DocumentMarker::Spelling);
-            m_frame->document()->markers()->removeMarkers(wordRange.get(), DocumentMarker::Replacement);
+            m_frame->document()->markers()->removeMarkers(wordRange.get(), DocumentMarker::CorrectionIndicator);
         }
         if (RefPtr<Range> sentenceRange = newSelectedSentence.toNormalizedRange())