Changeset 68948 in webkit


Ignore:
Timestamp:
Oct 1, 2010 4:21:29 PM (13 years ago)
Author:
tony@chromium.org
Message:

2010-10-01 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

editing/selection/5354455-1 has incorrect description text
https://bugs.webkit.org/show_bug.cgi?id=44990

This test includes descriptive text that describes an OS X-specific behavior.
I almost checked in an incorrect baseline because I believed the text.
This change amends the text to describe expected behavior on Mac/Win/Linux.

Rather than requiring new baselines on all platforms, I took this opportunity
to also convert the test to a markup dump. We'll then end up with just one
Mac baseline and one non-Mac baseline.

  • editing/selection/5354455-1.html:
  • platform/chromium-linux/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/5354455-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/5354455-1-expected.png: Removed.
  • platform/mac/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/mac/editing/selection/5354455-1-expected.png: Removed.
  • platform/mac/editing/selection/5354455-1-expected.txt: Updated.
  • platform/win/editing/selection/5354455-1-expected.txt: Added.
Location:
trunk/LayoutTests
Files:
1 added
9 deleted
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r68943 r68948  
     12010-10-01  Evan Martin  <evan@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        editing/selection/5354455-1 has incorrect description text
     6        https://bugs.webkit.org/show_bug.cgi?id=44990
     7
     8        This test includes descriptive text that describes an OS X-specific behavior.
     9        I almost checked in an incorrect baseline because I believed the text.
     10        This change amends the text to describe expected behavior on Mac/Win/Linux.
     11
     12        Rather than requiring new baselines on all platforms, I took this opportunity
     13        to also convert the test to a markup dump.  We'll then end up with just one
     14        Mac baseline and one non-Mac baseline.
     15
     16        * editing/selection/5354455-1.html:
     17        * platform/chromium-linux/editing/selection/5354455-1-expected.checksum: Removed.
     18        * platform/chromium-linux/editing/selection/5354455-1-expected.png: Removed.
     19        * platform/chromium-win/editing/selection/5354455-1-expected.checksum: Removed.
     20        * platform/chromium-win/editing/selection/5354455-1-expected.png: Removed.
     21        * platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
     22        * platform/chromium/test_expectations.txt:
     23        * platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
     24        * platform/mac-leopard/editing/selection/5354455-1-expected.checksum: Removed.
     25        * platform/mac-leopard/editing/selection/5354455-1-expected.png: Removed.
     26        * platform/mac/editing/selection/5354455-1-expected.checksum: Removed.
     27        * platform/mac/editing/selection/5354455-1-expected.png: Removed.
     28        * platform/mac/editing/selection/5354455-1-expected.txt: Updated.
     29        * platform/win/editing/selection/5354455-1-expected.txt: Added.
     30
    1312010-09-30  Zhenyao Mo  <zmo@google.com>
    232
  • trunk/LayoutTests/editing/selection/5354455-1.html

    r24561 r68948  
    1 <p>This tests to make sure that right clicking on a paragraph break in editable content selects it.  To run it manually, right click on the paragraph break after the first paragraph below.</p>
     1<script src="../../resources/dump-as-markup.js"></script>
     2
     3<p>This tests whether right clicking on a paragraph break in editable content selects it.  The break should be selected on OS X, but not on Windows or Linux.  To run it manually, right click on the paragraph break after the first paragraph below.</p>
     4<div id="dump">
    25<div id="div" contenteditable="true">
    3 <div><span id="text">The paragraph break should be selected.</span></div>
     6<div><span id="text">The following paragraph break should be selected on OS X.</span></div>
    47<br>
     8</div>
    59</div>
    610
     
    1519    eventSender.mouseUp();
    1620    // Right click on the paragraph break to select it.
    17     eventSender.contextClick();   
     21    eventSender.contextClick();
    1822}
     23Markup.dump(document.getElementById("dump"));
    1924</script>
    2025
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r68943 r68948  
    840840// End SVG Regressions
    841841// -----------------------------------------------------------------
    842 
    843 // Selection wrong.
    844 BUG10292 MAC LINUX : editing/selection/5354455-1.html = FAIL
    845842
    846843// Compact support was removed from WebKit by Hyatt and layout tests rebaselined in r40259.
  • trunk/LayoutTests/platform/gtk/editing/selection/5354455-1-expected.txt

    r63295 r68948  
    1 layer at (0,0) size 800x600
    2   RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x600
    4   RenderBlock {HTML} at (0,0) size 800x600
    5     RenderBody {BODY} at (8,8) size 784x584
    6       RenderBlock {P} at (0,0) size 784x40
    7         RenderText {#text} at (0,0) size 766x40
    8           text run at (0,0) width 578: "This tests to make sure that right clicking on a paragraph break in editable content selects it. "
    9           text run at (578,0) width 188: "To run it manually, right click"
    10           text run at (0,20) width 342: "on the paragraph break after the first paragraph below."
    11       RenderBlock {DIV} at (0,56) size 784x40
    12         RenderBlock {DIV} at (0,0) size 784x20
    13           RenderInline {SPAN} at (0,0) size 254x20
    14             RenderText {#text} at (0,0) size 254x20
    15               text run at (0,0) width 254: "The paragraph break should be selected."
    16         RenderBlock (anonymous) at (0,20) size 784x20
    17           RenderBR {BR} at (0,0) size 0x20
    18 caret: position 39 of child 0 {#text} of child 0 {SPAN} of child 1 {DIV} of child 2 {DIV} of body
     1| "
     2"
     3| <div>
     4|   contenteditable="true"
     5|   id="div"
     6|   "
     7"
     8|   <div>
     9|     <span>
     10|       id="text"
     11|       "The following paragraph break should be selected on OS X.<#selection-caret>"
     12|   "
     13"
     14|   <br>
     15|   "
     16"
     17| "
     18"
  • trunk/LayoutTests/platform/mac/editing/selection/5354455-1-expected.txt

    r63291 r68948  
    1 layer at (0,0) size 800x600
    2   RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x600
    4   RenderBlock {HTML} at (0,0) size 800x600
    5     RenderBody {BODY} at (8,8) size 784x584
    6       RenderBlock {P} at (0,0) size 784x36
    7         RenderText {#text} at (0,0) size 766x36
    8           text run at (0,0) width 578: "This tests to make sure that right clicking on a paragraph break in editable content selects it. "
    9           text run at (578,0) width 188: "To run it manually, right click"
    10           text run at (0,18) width 342: "on the paragraph break after the first paragraph below."
    11       RenderBlock {DIV} at (0,52) size 784x36
    12         RenderBlock {DIV} at (0,0) size 784x18
    13           RenderInline {SPAN} at (0,0) size 254x18
    14             RenderText {#text} at (0,0) size 254x18
    15               text run at (0,0) width 254: "The paragraph break should be selected."
    16         RenderBlock (anonymous) at (0,18) size 784x18
    17           RenderBR {BR} at (0,0) size 0x18
    18 selection start: position 39 of child 0 {#text} of child 0 {SPAN} of child 1 {DIV} of child 2 {DIV} of body
    19 selection end:   position 0 of child 3 {BR} of child 2 {DIV} of body
     1| "
     2"
     3| <div>
     4|   contenteditable="true"
     5|   id="div"
     6|   "
     7"
     8|   <div>
     9|     <span>
     10|       id="text"
     11|       "The following paragraph break should be selected on OS X.<#selection-anchor>"
     12|   "
     13"
     14|   <#selection-focus>
     15|   <br>
     16|   "
     17"
     18| "
     19"
Note: See TracChangeset for help on using the changeset viewer.