Changeset 68970 in webkit

Timestamp:

Oct 1, 2010 8:22:06 PM (14 years ago)

Author:

Martin Robinson

Message:

2010-10-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] r68923 broke some plugin tests
​https://bugs.webkit.org/show_bug.cgi?id=47040

No longer pass focus and blur events to plugins when the "old" DOM Level
2 DOMFocusIn/DOMFocusOut events occur. r68923 made a change which means
that the DOM Level 3 version is always fired for this event.

No new tests, as this should cause the failing tests to pass.

• plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): No longer pass focus and blur events to plugins when DOMFocusIn / DOMFocusOut events occur.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/PluginView.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-01  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Adam Barth.
+
+        [GTK] r68923 broke some plugin tests
+        https://bugs.webkit.org/show_bug.cgi?id=47040
+
+        No longer pass focus and blur events to plugins when the "old" DOM Level
+        2 DOMFocusIn/DOMFocusOut events occur. r68923 made a change which means
+        that the DOM Level 3 version is always fired for this event. 
+
+        No new tests, as this should cause the failing tests to pass.
+
+        * plugins/PluginView.cpp:
+        (WebCore::PluginView::handleEvent): No longer pass focus and blur events to
+        plugins when DOMFocusIn / DOMFocusOut events occur.
+
 2010-10-01  Anders Carlsson  <andersca@apple.com>
 

trunk/WebCore/plugins/PluginView.cpp

@@ -171 +171 @@
         handleKeyboardEvent(static_cast<KeyboardEvent*>(event));
 #if defined(XP_UNIX) && ENABLE(NETSCAPE_PLUGIN_API)
-    else if (event->type() == eventNames().DOMFocusOutEvent || event->type() == eventNames().focusoutEvent)
+    else if (event->type() == eventNames().focusoutEvent)
         handleFocusOutEvent();
-    else if (event->type() == eventNames().DOMFocusInEvent || event->type() == eventNames().focusinEvent)
+    else if (event->type() == eventNames().focusinEvent)
         handleFocusInEvent();
 #endif