Changeset 68985 in webkit

Timestamp:

Oct 3, 2010 2:00:22 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-10-03 Adam Barth <​abarth@webkit.org>

Reviewed by Holger Freyther.

All the WebSocket tests crash
​https://bugs.webkit.org/show_bug.cgi?id=47056

More code that tries to hold onto temporaries with references.

• websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• websockets/WebSocketChannel.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-03  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Holger Freyther.
+
+        All the WebSocket tests crash
+        https://bugs.webkit.org/show_bug.cgi?id=47056
+
+        More code that tries to hold onto temporaries with references.
+
+        * websockets/WebSocketChannel.cpp:
+        (WebCore::WebSocketChannel::didOpen):
+
 2010-10-03  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/websockets/WebSocketChannel.cpp

@@ -158 +158 @@
         controller->willSendWebSocketHandshakeRequest(identifier(), m_handshake.clientHandshakeRequest());
 #endif
-    const CString& handshakeMessage = m_handshake.clientHandshakeMessage();
+    CString handshakeMessage = m_handshake.clientHandshakeMessage();
     if (!handle->send(handshakeMessage.data(), handshakeMessage.length())) {
         m_context->addMessage(JSMessageSource, LogMessageType, ErrorMessageLevel, "Error sending handshake message.", 0, m_handshake.clientOrigin());