Changeset 69038 in webkit


Ignore:
Timestamp:
Oct 4, 2010 2:56:14 PM (13 years ago)
Author:
abarth@webkit.org
Message:

2010-10-04 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Remove ENABLE_SANDBOX
https://bugs.webkit.org/show_bug.cgi?id=47032

  • Configurations/FeatureDefines.xcconfig:

2010-10-04 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Remove ENABLE_SANDBOX
https://bugs.webkit.org/show_bug.cgi?id=47032

I'm not sure there's a reason for this to be behind a compile flag
anymore.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • features.pri:
  • html/HTMLIFrameElement.cpp: (WebCore::parseSandboxAttribute): (WebCore::HTMLIFrameElement::parseMappedAttribute):
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r68899 r69038  
     12010-10-04  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Remove ENABLE_SANDBOX
     6        https://bugs.webkit.org/show_bug.cgi?id=47032
     7
     8        * Configurations/FeatureDefines.xcconfig:
     9
    1102010-10-01  Pratik Solanki  <psolanki@apple.com>
    211
  • trunk/JavaScriptCore/Configurations/FeatureDefines.xcconfig

    r68802 r69038  
    9494ENABLE_RUBY_macosx = ENABLE_RUBY;
    9595
    96 ENABLE_SANDBOX = $(ENABLE_SANDBOX_$(REAL_PLATFORM_NAME));
    97 ENABLE_SANDBOX_macosx = ENABLE_SANDBOX;
    98 
    9996ENABLE_SHARED_WORKERS = $(ENABLE_SHARED_WORKERS_$(REAL_PLATFORM_NAME));
    10097ENABLE_SHARED_WORKERS_macosx = ENABLE_SHARED_WORKERS;
     
    125122ENABLE_XSLT = ENABLE_XSLT;
    126123
    127 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_IMAGE_RESIZER) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PROGRESS_TAG) $(ENABLE_RUBY) $(ENABLE_SANDBOX) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);
     124FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_IMAGE_RESIZER) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PROGRESS_TAG) $(ENABLE_RUBY) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);
  • trunk/WebCore/ChangeLog

    r69034 r69038  
     12010-10-04  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Remove ENABLE_SANDBOX
     6        https://bugs.webkit.org/show_bug.cgi?id=47032
     7
     8        I'm not sure there's a reason for this to be behind a compile flag
     9        anymore.
     10
     11        * Configurations/FeatureDefines.xcconfig:
     12        * GNUmakefile.am:
     13        * features.pri:
     14        * html/HTMLIFrameElement.cpp:
     15        (WebCore::parseSandboxAttribute):
     16        (WebCore::HTMLIFrameElement::parseMappedAttribute):
     17
    1182010-10-04  Huahui Wu  <mediadependent@gmail.com>
    219
  • trunk/WebCore/Configurations/FeatureDefines.xcconfig

    r68802 r69038  
    9595ENABLE_RUBY_macosx = ENABLE_RUBY;
    9696
    97 ENABLE_SANDBOX = $(ENABLE_SANDBOX_$(REAL_PLATFORM_NAME));
    98 ENABLE_SANDBOX_macosx = ENABLE_SANDBOX;
    99 
    10097ENABLE_SHARED_WORKERS = $(ENABLE_SHARED_WORKERS_$(REAL_PLATFORM_NAME));
    10198ENABLE_SHARED_WORKERS_macosx = ENABLE_SHARED_WORKERS;
     
    126123ENABLE_XSLT = ENABLE_XSLT;
    127124
    128 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_IMAGE_RESIZER) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PROGRESS_TAG) $(ENABLE_RUBY) $(ENABLE_SANDBOX) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);
     125FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_IMAGE_RESIZER) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PROGRESS_TAG) $(ENABLE_RUBY) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);
  • trunk/WebCore/GNUmakefile.am

    r68996 r69038  
    39093909
    39103910# ----
    3911 # Sandboxed IFrame Support
    3912 # ----
    3913 if ENABLE_SANDBOX
    3914 HTML_FEATURES += ENABLE_SANDBOX=1
    3915 webcore_cppflags += -DENABLE_SANDBOX=1
    3916 endif # END ENABLE_SANDBOX
    3917 
    3918 # ----
    39193911# Ruby Support
    39203912# ----
  • trunk/WebCore/features.pri

    r68510 r69038  
    6262!contains(DEFINES, ENABLE_DATAGRID=.): DEFINES += ENABLE_DATAGRID=0
    6363!contains(DEFINES, ENABLE_RUBY=.): DEFINES += ENABLE_RUBY=1
    64 !contains(DEFINES, ENABLE_SANDBOX=.): DEFINES += ENABLE_SANDBOX=1
    6564!contains(DEFINES, ENABLE_METER_TAG=.): DEFINES += ENABLE_METER_TAG=1
    6665!contains(DEFINES, ENABLE_PROGRESS_TAG=.): DEFINES += ENABLE_PROGRESS_TAG=1
  • trunk/WebCore/html/HTMLIFrameElement.cpp

    r59773 r69038  
    6868}
    6969
    70 #if ENABLE(SANDBOX)
    7170static SandboxFlags parseSandboxAttribute(Attribute* attribute)
    7271{
     
    104103    return flags;
    105104}
    106 #endif
    107105
    108106void HTMLIFrameElement::parseMappedAttribute(Attribute* attr)
     
    128126            // Add a rule that nulls out our border width.
    129127            addCSSLength(attr, CSSPropertyBorderWidth, "0");
    130     }
    131 #if ENABLE(SANDBOX)
    132     else if (attr->name() == sandboxAttr)
     128    } else if (attr->name() == sandboxAttr)
    133129        setSandboxFlags(parseSandboxAttribute(attr));
    134 #endif
    135130    else
    136131        HTMLFrameElementBase::parseMappedAttribute(attr);
Note: See TracChangeset for help on using the changeset viewer.