Changeset 69063 in webkit


Ignore:
Timestamp:
Oct 4, 2010 9:03:35 PM (14 years ago)
Author:
chang.shu@nokia.com
Message:

2010-10-04 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Fixed the typo that searches the wrong direction in the no-focus-node case.
As a result, after page is loaded, pressing key "arrowdown" will bring the
focus to the 1st element instead of the last element.
​https://bugs.webkit.org/show_bug.cgi?id=46901

  • fast/events/spatial-navigation/snav-1st-stop-expected.txt: Added.
  • fast/events/spatial-navigation/snav-1st-stop.html: Added.

2010-10-04 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Fixed the typo that searches the wrong direction in the no-focus-node case.
As a result, after page is loaded, pressing key "arrowdown" will bring the
focus to the 1st element instead of the last element.
​https://bugs.webkit.org/show_bug.cgi?id=46901

Test: fast/events/spatial-navigation/snav-1st-stop.html

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r69059 r69063  
     12010-10-04  Chang Shu  <chang.shu@nokia.com>
     2
     3        Reviewed by Antonio Gomes.
     4
     5        Fixed the typo that searches the wrong direction in the no-focus-node case.
     6        As a result, after page is loaded, pressing key "arrowdown" will bring the
     7        focus to the 1st element instead of the last element.
     8        https://bugs.webkit.org/show_bug.cgi?id=46901
     9
     10        * fast/events/spatial-navigation/snav-1st-stop-expected.txt: Added.
     11        * fast/events/spatial-navigation/snav-1st-stop.html: Added.
     12
    1132010-10-04  Kent Tamura  <tkent@chromium.org>
    214

  • trunk/WebCore/ChangeLog

    r69062 r69063  
     12010-10-04  Chang Shu  <chang.shu@nokia.com>
     2
     3        Reviewed by Antonio Gomes.
     4
     5        Fixed the typo that searches the wrong direction in the no-focus-node case.
     6        As a result, after page is loaded, pressing key "arrowdown" will bring the
     7        focus to the 1st element instead of the last element.
     8        https://bugs.webkit.org/show_bug.cgi?id=46901
     9
     10        Test: fast/events/spatial-navigation/snav-1st-stop.html
     11
     12        * page/FocusController.cpp:
     13        (WebCore::FocusController::advanceFocusDirectionally):
     14
    1152010-10-04  Simon Fraser  <simon.fraser@apple.com>
    216

  • trunk/WebCore/page/FocusController.cpp

    r67238 r69063  
    299299        // Just move to the first focusable node.
    300300        FocusDirection tabDirection = (direction == FocusDirectionUp || direction == FocusDirectionLeft) ?
    301                                        FocusDirectionForward : FocusDirectionBackward;
     301                                       FocusDirectionBackward : FocusDirectionForward;
    302302        // 'initialFocus' is set to true so the chrome is not focused.
    303303        return advanceFocusInDocumentOrder(tabDirection, event, true);
Note: See TracChangeset for help on using the changeset viewer.