Changeset 69097 in webkit

Timestamp:

Oct 5, 2010 1:42:47 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-05 Sanjeev Radhakrishnan <​sanjeevr@chromium.org>

Reviewed by Darin Fisher.

Fixed implementation of pluginWidgetFromDocument to search for the "embed" element rather than just use the first child.
​https://bugs.webkit.org/show_bug.cgi?id=47129

• html/PluginDocument.cpp: (WebCore::PluginDocumentParser::pluginWidgetFromDocument):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/PluginDocument.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-05  Sanjeev Radhakrishnan  <sanjeevr@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        Fixed implementation of pluginWidgetFromDocument to search for the "embed" element rather than just use the first child.
+        https://bugs.webkit.org/show_bug.cgi?id=47129
+
+        * html/PluginDocument.cpp:
+        (WebCore::PluginDocumentParser::pluginWidgetFromDocument):
+
 2010-10-05  Chris Rogers  <crogers@google.com>
 

trunk/WebCore/html/PluginDocument.cpp

@@ -33 +33 @@
 #include "HTMLNames.h"
 #include "MainResourceLoader.h"
+#include "NodeList.h"
 #include "Page.h"
 #include "RawDataDocumentParser.h"
@@ -71 +72 @@
     RefPtr<Element> body = doc->body();
     if (body) {
-        RefPtr<Node> node = body->firstChild();
+        RefPtr<NodeList> embedNodes = body->getElementsByTagName("embed");
+        ASSERT(embedNodes && embedNodes->length());
+        Node* node = embedNodes->item(0);
         if (node && node->renderer()) {
             ASSERT(node->renderer()->isEmbeddedObject());