Changeset 69114 in webkit

Timestamp:

Oct 5, 2010 9:42:34 AM (14 years ago)

Author:

kseo@webkit.org

Message:

[BREWMP] Use PlatformRefPtr in getDisplayInfo
​https://bugs.webkit.org/show_bug.cgi?id=47023

Reviewed by Kent Tamura.

Use PlatformRefPtr to release IBitmap* automatically.

• platform/brew/ScreenBrew.cpp:

(WebCore::getDisplayInfo):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/brew/ScreenBrew.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-05  Kwang Yul Seo  <skyul@company100.net>
+
+        Reviewed by Kent Tamura.
+
+        [BREWMP] Use PlatformRefPtr in getDisplayInfo
+        https://bugs.webkit.org/show_bug.cgi?id=47023
+
+        Use PlatformRefPtr to release IBitmap* automatically.
+
+        * platform/brew/ScreenBrew.cpp:
+        (WebCore::getDisplayInfo):
+
 2010-10-05  Kristian Monsen  <kristianm@google.com>
 

trunk/WebCore/platform/brew/ScreenBrew.cpp

@@ -37 +37 @@
 #include <AEEAppGen.h>
 #include <AEEStdLib.h>
+#include <wtf/brew/RefPtrBrew.h>
 
 namespace WebCore {
@@ -49 +50 @@
 {
     IDisplay* display = reinterpret_cast<AEEApplet*>(GETAPPINSTANCE())->m_pIDisplay;
-    IBitmap* bitmap = IDisplay_GetDestination(display);
-    ASSERT(bitmap);
+    PlatformRefPtr<IBitmap> bitmap = adoptPlatformRef(IDisplay_GetDestination(display));
 
     AEEBitmapInfo bitmapInfo;
-    IBitmap_GetInfo(bitmap, &bitmapInfo, sizeof(AEEBitmapInfo));
+    IBitmap_GetInfo(bitmap.get(), &bitmapInfo, sizeof(AEEBitmapInfo));
 
     info.width  = bitmapInfo.cx;
     info.height = bitmapInfo.cy;
     info.depth  = bitmapInfo.nDepth;
-
-    IBitmap_Release(bitmap);
 }