Changeset 69126 in webkit


Ignore:
Timestamp:
Oct 5, 2010 10:58:18 AM (14 years ago)
Author:
tony@chromium.org
Message:

2010-10-05 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] properly paint really small scrollbar arrows on linux
​https://bugs.webkit.org/show_bug.cgi?id=47109

  • platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.checksum:
  • platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.png:
  • platform/chromium/test_expectations.txt: Remove passing test and remove windows test that has no failures on

the dashboard

2010-10-05 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] properly paint really small scrollbar arrows on linux
​https://bugs.webkit.org/show_bug.cgi?id=47109

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::buttonSize): Clamp button size based on available size. This matches what

we do on Win.

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r69123 r69126  
     12010-10-05  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        [chromium] properly paint really small scrollbar arrows on linux
     6        https://bugs.webkit.org/show_bug.cgi?id=47109
     7
     8        * platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.checksum:
     9        * platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.png:
     10        * platform/chromium/test_expectations.txt: Remove passing test and remove windows test that has no failures on
     11            the dashboard
     12
    1132010-10-04  Jeremy Orlow  <jorlow@chromium.org>
    214

  • trunk/LayoutTests/platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.checksum

    r67091 r69126  
    1 dcd87ca252c589089a74b3e4560ac5ca
     121e88899981167b85280efa884077f15

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r69102 r69126  
    21872187BUG35329 WIN : http/tests/appcache/resource-redirect-2.html = TIMEOUT PASS
    21882188
    2189 // Webkit Roll to r51875
    2190 BUG29748 WIN DEBUG : fast/forms/input-align-image.html = IMAGE+TEXT PASS
    2191 
    2192 // The scrollbar arrows exceed the height of the iframe.
    2193 BUG29748 LINUX : fast/frames/onlyCommentInIFrame.html = IMAGE
    2194 
    21952189// More Webkit Roll to r51875
    21962190// Some of these went from IMAGE+TEXT to just IMAGE at r57886

  • trunk/WebCore/ChangeLog

    r69125 r69126  
     12010-10-05  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        [chromium] properly paint really small scrollbar arrows on linux
     6        https://bugs.webkit.org/show_bug.cgi?id=47109
     7
     8        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
     9        (WebCore::ScrollbarThemeChromiumLinux::buttonSize): Clamp button size based on available size.  This matches what
     10            we do on Win.
     11
    1122010-10-05  Nate Chapin  <japhet@chromium.org>
    213

  • trunk/WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp

    r68564 r69126  
    191191{
    192192    if (scrollbar->orientation() == VerticalScrollbar)
    193         return IntSize(scrollbarThicknessValue, buttonLength);
     193        return IntSize(scrollbarThicknessValue, scrollbar->height() < 2 * buttonLength ? scrollbar->height() / 2 : buttonLength);
    194194
    195195    // HorizontalScrollbar
    196     return IntSize(buttonLength, scrollbarThicknessValue);
     196    return IntSize(scrollbar->width() < 2 * buttonLength ? scrollbar->width() / 2 : buttonLength, scrollbarThicknessValue);
    197197}
    198198
Note: See TracChangeset for help on using the changeset viewer.