Changeset 69171 in webkit

Timestamp:

Oct 5, 2010 8:38:51 PM (14 years ago)

Author:

tony@chromium.org

Message:

2010-10-05 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

fix the link to the expected image on windows
​https://bugs.webkit.org/show_bug.cgi?id=47228

• Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On

windows, the file must be opened in binary mode when writing
binary data.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/test_types/test_type_base.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-10-05  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        fix the link to the expected image on windows
+        https://bugs.webkit.org/show_bug.cgi?id=47228
+
+        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
+            windows, the file must be opened in binary mode when writing
+            binary data.
+
 2010-10-05  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/test_types/test_type_base.py

@@ -162 +162 @@
         """This method assumes that byte_array is already encoded
         into the right format."""
-        with codecs.open(file_path, "w", encoding=encoding) as file:
+        open_mode = 'w'
+        if encoding is None:
+            open_mode = 'w+b'
+        with codecs.open(file_path, open_mode, encoding=encoding) as file:
             file.write(contents)