Changeset 69427 in webkit


Ignore:
Timestamp:
Oct 8, 2010 3:32:57 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r68574.
​http://trac.webkit.org/changeset/68574
​https://bugs.webkit.org/show_bug.cgi?id=47433

[chromium] Breaks partial repaint of images while scrolling
(Requested by jamesr on #webkit).

  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Removed.
  • platform/mac/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/mac/svg/custom/image-rescale-expected.png: Removed.
  • platform/mac/svg/custom/image-rescale-expected.txt: Removed.
  • svg/custom/image-rescale.svg: Removed.
  • svg/custom/resources/image-rescale.jpg: Removed.

2010-10-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r68574.
​http://trac.webkit.org/changeset/68574
​https://bugs.webkit.org/show_bug.cgi?id=47433

[chromium] Breaks partial repaint of images while scrolling
(Requested by jamesr on #webkit).

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):
Location:
trunk
Files:
8 deleted
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r69425 r69427  
     12010-10-08  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r68574.
     4        http://trac.webkit.org/changeset/68574
     5        https://bugs.webkit.org/show_bug.cgi?id=47433
     6
     7        [chromium] Breaks partial repaint of images while scrolling
     8        (Requested by jamesr on #webkit).
     9
     10        * platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Removed.
     11        * platform/chromium-linux/svg/custom/image-rescale-expected.png: Removed.
     12        * platform/chromium-linux/svg/custom/image-rescale-expected.txt: Removed.
     13        * platform/mac/svg/custom/image-rescale-expected.checksum: Removed.
     14        * platform/mac/svg/custom/image-rescale-expected.png: Removed.
     15        * platform/mac/svg/custom/image-rescale-expected.txt: Removed.
     16        * svg/custom/image-rescale.svg: Removed.
     17        * svg/custom/resources/image-rescale.jpg: Removed.
     18
    1192010-10-08  Adam Barth  <abarth@webkit.org>
    220

  • trunk/WebCore/ChangeLog

    r69426 r69427  
     12010-10-08  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r68574.
     4        http://trac.webkit.org/changeset/68574
     5        https://bugs.webkit.org/show_bug.cgi?id=47433
     6
     7        [chromium] Breaks partial repaint of images while scrolling
     8        (Requested by jamesr on #webkit).
     9
     10        * platform/graphics/skia/ImageSkia.cpp:
     11        (WebCore::computeResamplingMode):
     12        (WebCore::drawResampledBitmap):
     13
    1142010-10-08  Andy Estes  <aestes@apple.com>
    215

  • trunk/WebCore/platform/graphics/skia/ImageSkia.cpp

    r68574 r69427  
    144144    // Everything else gets resampled.
    145145    // If the platform context permits high quality interpolation, use it.
    146     // High quality interpolation only enabled for scaling and translation.
    147     if (platformContext->interpolationQuality() == InterpolationHigh
    148         && !(platformContext->canvas()->getTotalMatrix().getType() & (SkMatrix::kAffine_Mask | SkMatrix::kPerspective_Mask)))
     146    if (platformContext->interpolationQuality() == InterpolationHigh)
    149147        return RESAMPLE_AWESOME;
    150148   
    … …  
    176174
    177175    // We will always draw in integer sizes, so round the destination rect.
    178     // First we need to apply canvas transformation matrix to get desired size of
    179     // resampled image.
    180     SkRect destRectTransformed;
    181     canvas.getTotalMatrix().mapRect(&destRectTransformed, destRect);
    182176    SkIRect destRectRounded;
    183     destRectTransformed.round(&destRectRounded);
     177    destRect.round(&destRectRounded);
    184178    SkIRect resizedImageRect =  // Represents the size of the resized image.
    185179        { 0, 0, destRectRounded.width(), destRectRounded.height() };
    … …  
    195189    SkRect destBitmapSubsetSk;
    196190    ClipRectToCanvas(canvas, destRect, &destBitmapSubsetSk);
    197     // Determine size of resampled image based on clipped destination rect.
    198     SkRect destBitmapSubsetSkTransformed;
    199     canvas.getTotalMatrix().mapRect(&destBitmapSubsetSkTransformed, destBitmapSubsetSk);
    200     destBitmapSubsetSkTransformed.offset(-destBitmapSubsetSkTransformed.fLeft, -destBitmapSubsetSkTransformed.fTop);
     191    destBitmapSubsetSk.offset(-destRect.fLeft, -destRect.fTop);
    201192
    202193    // The matrix inverting, etc. could have introduced rounding error which
    … …  
    206197    // data.
    207198    SkIRect destBitmapSubsetSkI;
    208     destBitmapSubsetSkTransformed.roundOut(&destBitmapSubsetSkI);
     199    destBitmapSubsetSk.roundOut(&destBitmapSubsetSkI);
    209200    if (!destBitmapSubsetSkI.intersect(resizedImageRect))
    210201        return;  // Resized image does not intersect.
Note: See TracChangeset for help on using the changeset viewer.