Changeset 69701 in webkit

Timestamp:

Oct 13, 2010 3:24:58 PM (14 years ago)

Author:

Martin Robinson

Message:

2010-10-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Holger Freyther.

[GTK] r69681 caused some tests to crash
​https://bugs.webkit.org/show_bug.cgi?id=47622

Properly initialize m_layerContext on the ContextShadow so that in situations
where beginShadowLayer bails out early with a null return value, it is set
to null. This may happen when the first call to beginShadowLayer on a particular
ContextShadow uses a region which is entirely outside the clip region or which
is empty.

• platform/graphics/cairo/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): Properly initialize m_layerContext.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/ContextShadow.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-13  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Holger Freyther.
+
+        [GTK] r69681 caused some tests to crash
+        https://bugs.webkit.org/show_bug.cgi?id=47622
+
+        Properly initialize m_layerContext on the ContextShadow so that in situations
+        where beginShadowLayer bails out early with a null return value, it is set
+        to null. This may happen when the first call to beginShadowLayer on a particular
+        ContextShadow uses a region which is entirely outside the clip region or which
+        is empty.
+
+        * platform/graphics/cairo/ContextShadow.cpp:
+        (WebCore::ContextShadow::ContextShadow): Properly initialize m_layerContext.
+
 2010-10-13  Anders Carlsson  <andersca@apple.com>
 

trunk/WebCore/platform/graphics/ContextShadow.cpp

@@ -41 +41 @@
     : m_type(NoShadow)
     , m_blurDistance(0)
+    , m_layerContext(0)
 {
 }
@@ -48 +49 @@
     , m_blurDistance(round(radius))
     , m_offset(offset)
+    , m_layerContext(0)
 {
     // See comments in http://webkit.org/b/40793, it seems sensible