Changeset 69736 in webkit
- Timestamp:
- Oct 13, 2010 10:00:17 PM (13 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r69718 r69736 1 2010-10-13 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 Introduce the ChromiumXVFBPort for running commit-queue on EC2 6 https://bugs.webkit.org/show_bug.cgi?id=47653 7 8 I'm not entirely sure this is the best way to do this, but we need to 9 run the tests under XVFB on EC2 because the EC2 instances don't have a 10 real monitor hooked up. This patch adds a ChromiumXVFBPort that runs 11 that way. The idea is that XVFB is like a platform for the Chromium 12 port, but we don't have a real notion of platform separate from port. 13 14 * Scripts/webkitpy/common/config/ports.py: 15 1 16 2010-10-13 Sergio Villar Senin <svillar@igalia.com> 2 17 -
trunk/WebKitTools/Scripts/webkitpy/common/config/ports.py
r66564 r69736 46 46 ports = { 47 47 "chromium": ChromiumPort, 48 "chromium-xvfb": ChromiumXVFBPort, 48 49 "gtk": GtkPort, 49 50 "mac": MacPort, … … 218 219 command.append("--chromium") 219 220 return command 221 222 @classmethod 223 def run_webkit_tests_command(cls): 224 return [ 225 cls.script_path("new-run-webkit-tests"), 226 "--chromium", 227 "--use-drt", 228 "--no-pixel-tests", 229 ] 230 231 232 class ChromiumXVFBPort(ChromiumPort): 233 234 @classmethod 235 def flag(cls): 236 return "--port=chromium-xvfb" 237 238 @classmethod 239 def run_webkit_tests_command(cls): 240 # FIXME: We should find a better way to do this. 241 return ["xvfb-run"] + cls.run_webkit_tests_command() -
trunk/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py
r59379 r69736 65 65 self.assertEquals(ChromiumPort.name(), "Chromium") 66 66 self.assertEquals(ChromiumPort.flag(), "--port=chromium") 67 self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path(" run-webkit-tests")])67 self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("new-run-webkit-tests"), "--chromium", "--use-drt", "--no-pixel-tests"]) 68 68 self.assertEquals(ChromiumPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--chromium"]) 69 69 self.assertEquals(ChromiumPort.build_webkit_command(build_style="debug"), [WebKitPort.script_path("build-webkit"), "--debug", "--chromium"])
Note: See TracChangeset
for help on using the changeset viewer.