Changeset 69736 in webkit


Ignore:
Timestamp:
Oct 13, 2010 10:00:17 PM (13 years ago)
Author:
abarth@webkit.org
Message:

2010-10-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce the ChromiumXVFBPort for running commit-queue on EC2
https://bugs.webkit.org/show_bug.cgi?id=47653

I'm not entirely sure this is the best way to do this, but we need to
run the tests under XVFB on EC2 because the EC2 instances don't have a
real monitor hooked up. This patch adds a ChromiumXVFBPort that runs
that way. The idea is that XVFB is like a platform for the Chromium
port, but we don't have a real notion of platform separate from port.

  • Scripts/webkitpy/common/config/ports.py:
Location:
trunk/WebKitTools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r69718 r69736  
     12010-10-13  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Introduce the ChromiumXVFBPort for running commit-queue on EC2
     6        https://bugs.webkit.org/show_bug.cgi?id=47653
     7
     8        I'm not entirely sure this is the best way to do this, but we need to
     9        run the tests under XVFB on EC2 because the EC2 instances don't have a
     10        real monitor hooked up.  This patch adds a ChromiumXVFBPort that runs
     11        that way.  The idea is that XVFB is like a platform for the Chromium
     12        port, but we don't have a real notion of platform separate from port.
     13
     14        * Scripts/webkitpy/common/config/ports.py:
     15
    1162010-10-13  Sergio Villar Senin  <svillar@igalia.com>
    217
  • trunk/WebKitTools/Scripts/webkitpy/common/config/ports.py

    r66564 r69736  
    4646        ports = {
    4747            "chromium": ChromiumPort,
     48            "chromium-xvfb": ChromiumXVFBPort,
    4849            "gtk": GtkPort,
    4950            "mac": MacPort,
     
    218219        command.append("--chromium")
    219220        return command
     221
     222    @classmethod
     223    def run_webkit_tests_command(cls):
     224        return [
     225            cls.script_path("new-run-webkit-tests"),
     226            "--chromium",
     227            "--use-drt",
     228            "--no-pixel-tests",
     229        ]
     230
     231
     232class ChromiumXVFBPort(ChromiumPort):
     233
     234    @classmethod
     235    def flag(cls):
     236        return "--port=chromium-xvfb"
     237
     238    @classmethod
     239    def run_webkit_tests_command(cls):
     240        # FIXME: We should find a better way to do this.
     241        return ["xvfb-run"] + cls.run_webkit_tests_command()
  • trunk/WebKitTools/Scripts/webkitpy/common/config/ports_unittest.py

    r59379 r69736  
    6565        self.assertEquals(ChromiumPort.name(), "Chromium")
    6666        self.assertEquals(ChromiumPort.flag(), "--port=chromium")
    67         self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("run-webkit-tests")])
     67        self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("new-run-webkit-tests"), "--chromium", "--use-drt", "--no-pixel-tests"])
    6868        self.assertEquals(ChromiumPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--chromium"])
    6969        self.assertEquals(ChromiumPort.build_webkit_command(build_style="debug"), [WebKitPort.script_path("build-webkit"), "--debug", "--chromium"])
Note: See TracChangeset for help on using the changeset viewer.