Changeset 69841 in webkit

Timestamp:

Oct 14, 2010 11:52:54 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-14 Jia Pu <​jpu@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word
​https://bugs.webkit.org/show_bug.cgi?id=47689
<rdar://problem/8552250>

The test requires using setTimeout(). So we put it in manual-tests.

• editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): Relpace release() with clear(). (WebCore::Editor::startCorrectionPanelTimer): Release previously set correction range before start timer for next autocorrection check.
• manual-tests/autocorrection: Added.
• manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Added.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/Editor.cpp (modified) (2 diffs)
• manual-tests/autocorrection (added)
• manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html (added)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-14  Jia Pu  <jpu@apple.com>
+
+        Reviewed by Adele Peterson.
+
+        REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word
+        https://bugs.webkit.org/show_bug.cgi?id=47689
+        <rdar://problem/8552250>
+
+        The test requires using setTimeout(). So we put it in manual-tests.
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::markMisspellingsAfterTypingToPosition): Relpace release() with clear().
+        (WebCore::Editor::startCorrectionPanelTimer): Release previously set correction range before
+          start timer for next autocorrection check.
+        * manual-tests/autocorrection: Added.
+        * manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Added.
+
 2010-10-14  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/WebCore/editing/Editor.cpp

@@ -2448 +2448 @@
             }
         }
-        m_rangeToBeReplacedByCorrection.release();
+        m_rangeToBeReplacedByCorrection.clear();
     }
 #endif
@@ -2902 +2902 @@
 #if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
     static const double correctionPanelTimerInterval = 0.3;
-    if (isAutomaticSpellingCorrectionEnabled())
+    if (isAutomaticSpellingCorrectionEnabled()) {
+        m_rangeToBeReplacedByCorrection.clear();
         m_correctionPanelTimer.startOneShot(correctionPanelTimerInterval);
+    }
 #endif
 }