Changeset 69966 in webkit

Timestamp:

Oct 18, 2010 9:48:07 AM (14 years ago)

Author:

noam.rosenthal@nokia.com

Message:

2010-10-18 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] AC rendering bugs

This fixes a regression that was introduced by making scrolling in accelerated compositing automatic,
which made our explicit function to scroll the compositing layers superfluous, making the scrolling behavior
when graphics layers are present incorrect. The fix simply removes those redundant functions.

​https://bugs.webkit.org/show_bug.cgi?id=47571

• WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
• WebCoreSupport/PageClientQt.h:

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/PageClientQt.cpp (modified) (4 diffs)
• WebCoreSupport/PageClientQt.h (modified) (1 diff)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-10-18  No'am Rosenthal  <noam.rosenthal@nokia.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] AC rendering bugs
+
+        This fixes a regression that was introduced by making scrolling in accelerated compositing automatic,
+        which made our explicit function to scroll the compositing layers superfluous, making the scrolling behavior
+        when graphics layers are present incorrect. The fix simply removes those redundant functions.
+
+        https://bugs.webkit.org/show_bug.cgi?id=47571
+
+        * WebCoreSupport/PageClientQt.cpp:
+        (WebCore::PageClientQGraphicsWidget::scroll):
+        (WebCore::PageClientQGraphicsWidget::update):
+        (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
+        * WebCoreSupport/PageClientQt.h:
+
 2010-10-18  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 

trunk/WebKit/qt/WebCoreSupport/PageClientQt.cpp

@@ -119 +119 @@
 {
     view->scroll(qreal(dx), qreal(dy), rectToScroll);
-
-#if USE(ACCELERATED_COMPOSITING)
-    updateCompositingScrollPosition();
-#endif
 }
 
@@ -134 +130 @@
 #if USE(ACCELERATED_COMPOSITING)
     syncLayers();
-    // This might be a slow-scroll. We ensure that the compositing layers are in the right position.
-    updateCompositingScrollPosition();
 #endif
 }
@@ -186 +180 @@
         layer->setParentItem(view);
         layer->setZValue(RootGraphicsLayerZValue);
-        updateCompositingScrollPosition();
     }
     createOrDeleteOverlay();
@@ -198 +191 @@
 }
 
-void PageClientQGraphicsWidget::updateCompositingScrollPosition()
-{
-    if (rootGraphicsLayer && page && page->mainFrame()) {
-        const QPoint scrollPosition = page->mainFrame()->scrollPosition();
-        rootGraphicsLayer.data()->setPos(-scrollPosition);
-    }
-}
 #endif
 

trunk/WebKit/qt/WebCoreSupport/PageClientQt.h

@@ -171 +171 @@
     virtual void setRootGraphicsLayer(QGraphicsItem* layer);
     virtual void markForSync(bool scheduleSync);
-    void updateCompositingScrollPosition();
     void syncLayers();