Changeset 70039 in webkit


Ignore:
Timestamp:
Oct 19, 2010 1:48:57 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-19 Sergio Villar Senín <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/history tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=36173

Removed skipped tests from http/history

  • platform/gtk/Skipped:

2010-10-19 Sergio Villar Senín <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/history tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=36173

Clear the history each time a test is run. Return the actual
history item count when calling
LayoutTestController::webHistoryItemCount

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::webHistoryItemCount):
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r70032 r70039  
     12010-10-19  Sergio Villar Senín  <svillar@igalia.com>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] http/history tests are failing
     6        https://bugs.webkit.org/show_bug.cgi?id=36173
     7
     8        Removed skipped tests from http/history
     9
     10        * platform/gtk/Skipped:
     11
    1122010-10-18  Ryosuke Niwa  <rniwa@webkit.org>
    213

  • trunk/LayoutTests/platform/gtk/Skipped

    r69967 r70039  
    29622962http/tests/appcache/resource-redirect-2.html
    29632963http/tests/cookies/double-quoted-value-with-semi-colon.html
    2964 http/tests/history/redirect-200-refresh-2-seconds.pl
    2965 http/tests/history/redirect-js-document-location-0-seconds.html
    2966 http/tests/history/redirect-js-document-location-2-seconds.html
    2967 http/tests/history/redirect-js-document-location-before-load.html
    2968 http/tests/history/redirect-js-form-submit-0-seconds.html
    2969 http/tests/history/redirect-js-form-submit-2-seconds.html
    2970 http/tests/history/redirect-js-form-submit-before-load.html
    2971 http/tests/history/redirect-js-location-0-seconds.html
    2972 http/tests/history/redirect-js-location-2-seconds.html
    2973 http/tests/history/redirect-js-location-assign-0-seconds.html
    2974 http/tests/history/redirect-js-location-assign-2-seconds.html
    2975 http/tests/history/redirect-js-location-assign-before-load.html
    2976 http/tests/history/redirect-js-location-before-load.html
    2977 http/tests/history/redirect-js-location-href-0-seconds.html
    2978 http/tests/history/redirect-js-location-href-2-seconds.html
    2979 http/tests/history/redirect-js-location-href-before-load.html
    2980 http/tests/history/redirect-meta-refresh-2-seconds.html
    29812964http/tests/incremental/slow-utf8-text.pl
    29822965http/tests/loading/bad-scheme-subframe.html

  • trunk/WebKitTools/ChangeLog

    r70029 r70039  
     12010-10-19  Sergio Villar Senín  <svillar@igalia.com>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] http/history tests are failing
     6        https://bugs.webkit.org/show_bug.cgi?id=36173
     7
     8        Clear the history each time a test is run. Return the actual
     9        history item count when calling
     10        LayoutTestController::webHistoryItemCount
     11
     12        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     13        (resetDefaultsToConsistentValues):
     14        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     15        (LayoutTestController::webHistoryItemCount):
     16
    1172010-10-18  Eric Seidel  <eric@webkit.org>
    218

  • trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r69919 r70039  
    420420    webkit_reset_origin_access_white_lists();
    421421
     422    WebKitWebBackForwardList* list = webkit_web_view_get_back_forward_list(webView);
     423    webkit_web_back_forward_list_clear(list);
     424
    422425#ifdef HAVE_LIBSOUP_2_29_90
    423426    SoupSession* session = webkit_get_default_session();

  • trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r69952 r70039  
    184184size_t LayoutTestController::webHistoryItemCount()
    185185{
    186     // FIXME: implement
    187     return 0;
     186    WebKitWebView* webView = webkit_web_frame_get_web_view(mainFrame);
     187    WebKitWebBackForwardList* list = webkit_web_view_get_back_forward_list(webView);
     188
     189    if (!list)
     190        return -1;
     191
     192    // We do not add the current page to the total count as it's not
     193    // considered in DRT tests
     194    return webkit_web_back_forward_list_get_back_length(list) +
     195            webkit_web_back_forward_list_get_forward_length(list);
    188196}
    189197
Note: See TracChangeset for help on using the changeset viewer.