Changeset 70071 in webkit


Ignore:
Timestamp:
Oct 19, 2010 11:30:00 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-19 Jia Pu <​jpu@apple.com>

Reviewed by Adele Peterson.

Moving cursor back to autocorrected word in the same line shouldn't remove the underline
​https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>

  • platform/mac-leopard/Skipped: New tests don't apply to this Mac OSX version.
  • platform/mac-snowleopard/Skipped: Ditto.
  • platform/mac-tiger/Skipped: Ditto.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/mac/editing/spelling/autocorrection-delete-expected.checksum:
  • platform/mac/editing/spelling/autocorrection-delete-expected.png:
  • platform/mac/editing/spelling/click-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/click-autocorrected-word.html: Added.
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/delete-into-autocorrected-word.html: Added.
  • platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt: Added.
  • platform/mac/editing/spelling/delete-into-misspelled-word.html: Added.
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html: Added.
  • platform/mac/editing/spelling/move-cursor-around-misspelled-word-expected.txt: Added.
  • platform/mac/editing/spelling/move-cursor-around-misspelled-word.html: Added.
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html: Added.
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html: Added.

2010-10-19 Jia Pu <​jpu@apple.com>

Reviewed by Adele Peterson.

Moving cursor back to autocorrected word in the same line shouldn't remove the underline
​https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>

Tests: platform/mac/editing/spelling/click-autocorrected-word.html

platform/mac/editing/spelling/delete-into-autocorrected-word.html
platform/mac/editing/spelling/delete-into-misspelled-word.html
platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html

  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Don't remove misspelling or autocorrection underlines when cursor is moved onto a word.
Location:
trunk
Files:
24 added
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r70063 r70071  
     12010-10-19  Jia Pu  <jpu@apple.com>
     2
     3        Reviewed by Adele Peterson.
     4
     5        Moving cursor back to autocorrected word in the same line shouldn't remove the underline
     6        https://bugs.webkit.org/show_bug.cgi?id=47629
     7        <rdar://problem/8546758>
     8
     9        * platform/mac-leopard/Skipped: New tests don't apply to this Mac OSX version.
     10        * platform/mac-snowleopard/Skipped: Ditto.
     11        * platform/mac-tiger/Skipped: Ditto.
     12        * platform/mac-wk2/Skipped: Ditto.
     13        * platform/mac/editing/spelling/autocorrection-delete-expected.checksum:
     14        * platform/mac/editing/spelling/autocorrection-delete-expected.png:
     15        * platform/mac/editing/spelling/click-autocorrected-word-expected.checksum: Added.
     16        * platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
     17        * platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
     18        * platform/mac/editing/spelling/click-autocorrected-word.html: Added.
     19        * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum: Added.
     20        * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
     21        * platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
     22        * platform/mac/editing/spelling/delete-into-autocorrected-word.html: Added.
     23        * platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt: Added.
     24        * platform/mac/editing/spelling/delete-into-misspelled-word.html: Added.
     25        * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum: Added.
     26        * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
     27        * platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
     28        * platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html: Added.
     29        * platform/mac/editing/spelling/move-cursor-around-misspelled-word-expected.txt: Added.
     30        * platform/mac/editing/spelling/move-cursor-around-misspelled-word.html: Added.
     31        * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum: Added.
     32        * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
     33        * platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
     34        * platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html: Added.
     35        * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum: Added.
     36        * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
     37        * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
     38        * platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html: Added.
     39
    1402010-10-19  Eric Carlson  <eric.carlson@apple.com>
    241

  • trunk/LayoutTests/platform/mac-leopard/Skipped

    r69351 r70071  
    100100platform/mac/editing/spelling/autocorrection-removing-underline.html
    101101platform/mac/editing/spelling/autocorrection-simple.html
     102platform/mac/editing/spelling/click-autocorrected-word.html
     103platform/mac/editing/spelling/delete-into-autocorrected-word.html
     104platform/mac/editing/spelling/delete-into-misspelled-word.html
     105platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
     106platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
     107platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
     108platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html

  • trunk/LayoutTests/platform/mac-snowleopard/Skipped

    r69351 r70071  
    135135platform/mac/editing/spelling/autocorrection-removing-underline.html
    136136platform/mac/editing/spelling/autocorrection-simple.html
     137platform/mac/editing/spelling/click-autocorrected-word.html
     138platform/mac/editing/spelling/delete-into-autocorrected-word.html
     139platform/mac/editing/spelling/delete-into-misspelled-word.html
     140platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
     141platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
     142platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
     143platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html

  • trunk/LayoutTests/platform/mac-tiger/Skipped

    r69750 r70071  
    210210platform/mac/editing/spelling/autocorrection-removing-underline.html
    211211platform/mac/editing/spelling/autocorrection-simple.html
     212platform/mac/editing/spelling/click-autocorrected-word.html
     213platform/mac/editing/spelling/delete-into-autocorrected-word.html
     214platform/mac/editing/spelling/delete-into-misspelled-word.html
     215platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
     216platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
     217platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
     218platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html

  • trunk/LayoutTests/platform/mac-wk2/Skipped

    r69747 r70071  
    517517platform/mac/editing/spelling/autocorrection-removing-underline.html
    518518platform/mac/editing/spelling/autocorrection-simple.html
     519platform/mac/editing/spelling/click-autocorrected-word.html
     520platform/mac/editing/spelling/delete-into-autocorrected-word.html
     521platform/mac/editing/spelling/delete-into-misspelled-word.html
     522platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
     523platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
     524platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
     525platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
    519526platform/mac/fast/forms/input-appearance-spinbutton-up.html
    520527platform/mac/fast/forms/input-number-click.html

  • trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-delete-expected.checksum

    r69269 r70071  
    1 39685c692f4697ce0b957e38a07a2357
     1a7f7bb68b8cb6b37695a4e7b4f69a847

  • trunk/WebCore/ChangeLog

    r70065 r70071  
     12010-10-19  Jia Pu  <jpu@apple.com>
     2
     3        Reviewed by Adele Peterson.
     4
     5        Moving cursor back to autocorrected word in the same line shouldn't remove the underline
     6        https://bugs.webkit.org/show_bug.cgi?id=47629
     7        <rdar://problem/8546758>
     8
     9        Tests: platform/mac/editing/spelling/click-autocorrected-word.html
     10               platform/mac/editing/spelling/delete-into-autocorrected-word.html
     11               platform/mac/editing/spelling/delete-into-misspelled-word.html
     12               platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
     13               platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
     14               platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
     15               platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
     16
     17        * editing/Editor.cpp:
     18        (WebCore::Editor::respondToChangedSelection): Don't remove misspelling or autocorrection
     19          underlines when cursor is moved onto a word.
     20
    1212010-10-19  Eric Carlson  <eric.carlson@apple.com>
    222

  • trunk/WebCore/editing/Editor.cpp

    r69876 r70071  
    36103610        }
    36113611
     3612#if PLATFORM(MAC) && (defined(BUILDING_ON_TIGER) || defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD))
    36123613        // This only erases markers that are in the first unit (word or sentence) of the selection.
    3613         // Perhaps peculiar, but it matches AppKit.
    3614         if (RefPtr<Range> wordRange = newAdjacentWords.toNormalizedRange()) {
     3614        // Perhaps peculiar, but it matches AppKit on these Mac OSX versions.
     3615        if (RefPtr<Range> wordRange = newAdjacentWords.toNormalizedRange())
    36153616            m_frame->document()->markers()->removeMarkers(wordRange.get(), DocumentMarker::Spelling);
    3616             m_frame->document()->markers()->removeMarkers(wordRange.get(), DocumentMarker::CorrectionIndicator);
    3617         }
     3617#endif
    36183618        if (RefPtr<Range> sentenceRange = newSelectedSentence.toNormalizedRange())
    36193619            m_frame->document()->markers()->removeMarkers(sentenceRange.get(), DocumentMarker::Grammar);
Note: See TracChangeset for help on using the changeset viewer.