Changeset 70113 in webkit

Timestamp:

Oct 19, 2010 5:20:28 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-19 Jia Pu <​jpu@apple.com>

Reviewed by James Robinson.

Moving cursor back to autocorrected word in the same line shouldn't remove the underline
​https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>

Patch <​http://trac.webkit.org/changeset/70071> breaks some Chromium Mac hehavior. This patch
fixes that.

• editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Add "!PLATFORM(MAC)" to make sure nothing changes on non-Mac platforms.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/Editor.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-19  Jia Pu  <jpu@apple.com>
+
+        Reviewed by James Robinson.
+
+        Moving cursor back to autocorrected word in the same line shouldn't remove the underline
+        https://bugs.webkit.org/show_bug.cgi?id=47629
+        <rdar://problem/8546758>
+        
+        Patch <http://trac.webkit.org/changeset/70071> breaks some Chromium Mac hehavior. This patch
+        fixes that.
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::respondToChangedSelection): Add "!PLATFORM(MAC)" to make sure nothing changes
+          on non-Mac platforms.
+
 2010-10-19  Alexey Proskuryakov  <ap@apple.com>
 

trunk/WebCore/editing/Editor.cpp

@@ -3610 +3610 @@
         }
 
-#if PLATFORM(MAC) && (defined(BUILDING_ON_TIGER) || defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD))
+#if !PLATFORM(MAC) || (PLATFORM(MAC) && (defined(BUILDING_ON_TIGER) || defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD)))
         // This only erases markers that are in the first unit (word or sentence) of the selection.
         // Perhaps peculiar, but it matches AppKit on these Mac OSX versions.