Changeset 70114 in webkit

Timestamp:

Oct 19, 2010 6:08:08 PM (14 years ago)

Author:

evan@chromium.org

Message:

2010-10-19 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

sqlite: remove unused member variable
​https://bugs.webkit.org/show_bug.cgi?id=47957

There's no need to save the error code into a member variable
because nobody ever looks at it.

• platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open):
• platform/sql/SQLiteDatabase.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/sql/SQLiteDatabase.cpp (modified) (1 diff)
• platform/sql/SQLiteDatabase.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-19  Evan Martin  <evan@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        sqlite: remove unused member variable
+        https://bugs.webkit.org/show_bug.cgi?id=47957
+
+        There's no need to save the error code into a member variable
+        because nobody ever looks at it.
+
+        * platform/sql/SQLiteDatabase.cpp:
+        (WebCore::SQLiteDatabase::open):
+        * platform/sql/SQLiteDatabase.h:
+
 2010-10-19  Jia Pu  <jpu@apple.com>
 

trunk/WebCore/platform/sql/SQLiteDatabase.cpp

@@ -66 +66 @@
     close();
 
-    m_lastError = SQLiteFileSystem::openDatabase(filename, &m_db, forWebSQLDatabase);
-    if (m_lastError != SQLITE_OK) {
+    if (SQLiteFileSystem::openDatabase(filename, &m_db, forWebSQLDatabase) != SQLITE_OK) {
         LOG_ERROR("SQLite database failed to load from %s\nCause - %s", filename.ascii().data(),
             sqlite3_errmsg(m_db));

trunk/WebCore/platform/sql/SQLiteDatabase.h

@@ -140 +140 @@
     
     sqlite3* m_db;
-    int m_lastError;
     int m_pageSize;