Changeset 70158 in webkit

Timestamp:

Oct 20, 2010 11:17:36 AM (14 years ago)

Author:

hyatt@apple.com

Message:

​https://bugs.webkit.org/show_bug.cgi?id=47994

Reviewed by Simon Fraser.

Make computeBlockDirectionPositionsForLine writing-mode-aware. None of the functions it calls are patched yet.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlockLineLayout.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-20  David Hyatt  <hyatt@apple.com>
+
+        Reviewed by Simon Fraser.
+
+        https://bugs.webkit.org/show_bug.cgi?id=47994
+        
+        Make computeBlockDirectionPositionsForLine writing-mode-aware.  None of the functions it calls are patched yet.
+
+        * rendering/RenderBlockLineLayout.cpp:
+        (WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
+
 2010-10-20  John Abd-El-Malek  <jam@chromium.org>
 

trunk/WebCore/rendering/RenderBlockLineLayout.cpp

@@ -472 +472 @@
 void RenderBlock::computeBlockDirectionPositionsForLine(RootInlineBox* lineBox, BidiRun* firstRun, GlyphOverflowAndFallbackFontsMap& textBoxDataMap)
 {
-    setLogicalHeight(lineBox->alignBoxesInBlockDirection(height(), textBoxDataMap));
-    lineBox->setBlockLogicalHeight(height());
+    setLogicalHeight(lineBox->alignBoxesInBlockDirection(logicalHeight(), textBoxDataMap));
+    lineBox->setBlockLogicalHeight(logicalHeight());
 
     // Now make sure we place replaced render objects correctly.
@@ -484 +484 @@
         // a reasonable approximation of an appropriate y position.
         if (r->m_object->isPositioned())
-            r->m_box->setY(height());
+            r->m_box->setLogicalTop(logicalHeight());
 
         // Position is used to properly position both replaced elements and