Changeset 70251 in webkit


Ignore:
Timestamp:
Oct 21, 2010 11:13:34 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-21 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] TextBreakIteratorGtk should initialize its internal index to 0
​https://bugs.webkit.org/show_bug.cgi?id=48065

It fixes the following tests when using glib unicode:

fast/forms/ValidityState-tooLong-input.html
fast/forms/ValidityState-tooLong-textarea.html
fast/forms/input-appearance-maxlength.html
fast/forms/input-implicit-length-limit.html
fast/forms/input-maxlength.html
fast/forms/textarea-live-pseudo-selectors.html
fast/forms/mailto/advanced-get.html
fast/forms/mailto/advanced-put.html

  • platform/text/gtk/TextBreakIteratorGtk.cpp: (WebCore::setUpIterator):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r70250 r70251  
     12010-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GTK] TextBreakIteratorGtk should initialize its internal index to 0
     6        https://bugs.webkit.org/show_bug.cgi?id=48065
     7
     8        It fixes the following tests when using glib unicode:
     9          fast/forms/ValidityState-tooLong-input.html
     10          fast/forms/ValidityState-tooLong-textarea.html
     11          fast/forms/input-appearance-maxlength.html
     12          fast/forms/input-implicit-length-limit.html
     13          fast/forms/input-maxlength.html
     14          fast/forms/textarea-live-pseudo-selectors.html
     15          fast/forms/mailto/advanced-get.html
     16          fast/forms/mailto/advanced-put.html
     17
     18        * platform/text/gtk/TextBreakIteratorGtk.cpp:
     19        (WebCore::setUpIterator):
     20
    1212010-10-21  takano takumi  <takano1@asia.apple.com>
    222

  • trunk/WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp

    r55158 r70251  
    6969        g_free(iterator->m_logAttrs);
    7070    iterator->m_logAttrs = g_new0(PangoLogAttr, length + 1);
    71     iterator->m_index = -1;
     71    iterator->m_index = 0;
    7272    pango_get_log_attrs(utf8.get(), utf8len, -1, 0, iterator->m_logAttrs, length + 1);
    7373
Note: See TracChangeset for help on using the changeset viewer.