Changeset 70295 in webkit


Ignore:
Timestamp:
Oct 22, 2010 1:21:17 AM (14 years ago)
Author:
morrita@google.com
Message:

2010-10-22 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

​https://bugs.webkit.org/show_bug.cgi?id=47645
Conversion to text test: editing/spelling/spellcheck-attribute.html

Replaced a pixel test with test-based test using
LayoutTestController.hasSpellingMarker().

  • editing/spelling/spellcheck-attribute-expected.txt: Added.
  • editing/spelling/spellcheck-attribute.html:
  • platform/chromium-win/editing/spelling/spellcheck-attribute-expected.checksum: Removed.
  • platform/chromium-win/editing/spelling/spellcheck-attribute-expected.png: Removed.
  • platform/chromium-win/editing/spelling/spellcheck-attribute-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Removed.
  • platform/mac-leopard/editing/spelling/spellcheck-attribute-expected.checksum: Removed.
  • platform/mac-leopard/editing/spelling/spellcheck-attribute-expected.png: Removed.
  • platform/mac/editing/spelling/spellcheck-attribute-expected.checksum: Removed.
  • platform/mac/editing/spelling/spellcheck-attribute-expected.png: Removed.
  • platform/mac/editing/spelling/spellcheck-attribute-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
1 added
9 deleted
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r70293 r70295  
     12010-10-22  MORITA Hajime  <morrita@google.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=47645
     6        Conversion to text test: editing/spelling/spellcheck-attribute.html
     7       
     8        Replaced a pixel test with test-based test using
     9        LayoutTestController.hasSpellingMarker().
     10
     11        * editing/spelling/spellcheck-attribute-expected.txt: Added.
     12        * editing/spelling/spellcheck-attribute.html:
     13        * platform/chromium-win/editing/spelling/spellcheck-attribute-expected.checksum: Removed.
     14        * platform/chromium-win/editing/spelling/spellcheck-attribute-expected.png: Removed.
     15        * platform/chromium-win/editing/spelling/spellcheck-attribute-expected.txt: Removed.
     16        * platform/chromium/test_expectations.txt:
     17        * platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Removed.
     18        * platform/mac-leopard/editing/spelling/spellcheck-attribute-expected.checksum: Removed.
     19        * platform/mac-leopard/editing/spelling/spellcheck-attribute-expected.png: Removed.
     20        * platform/mac/editing/spelling/spellcheck-attribute-expected.checksum: Removed.
     21        * platform/mac/editing/spelling/spellcheck-attribute-expected.png: Removed.
     22        * platform/mac/editing/spelling/spellcheck-attribute-expected.txt: Removed.
     23
    1242010-10-21  James Simonsen  <simonjam@chromium.org>
    225

  • trunk/LayoutTests/editing/spelling/spellcheck-attribute.html

    r43168 r70295  
    66<body>
    77<p>This tests if the "spellcheck" attribute is implemented as written in its specification. If this test succeeds, you can see six forms filled with an invalid word 'zz '. Nevertheless, the 'zz ' only in the line 1.1, 1.2, and 2.2 are marked as misspelled.</p>
     8<div id="testRoot">
    89<div spellcheck="true">
    910<label>1.1.</label><input id="test1_1" type="text"></input><br/>
    … …  
    1617<label>2.3.</label><input id="test2_3" type="text" spellcheck="false"></input><br/>
    1718</div>
     19</div>
     20<pre id="console"></pre>
    1821<script>
    19 function typeInvalidWord(id) {
     22function log(msg) {
     23    document.getElementById("console").innerHTML += (msg + "\n");
     24}
     25
     26function testTypingInvalidWord(id, shouldBeMarked) {
    2027    document.getElementById(id).focus();
    2128    document.execCommand("InsertText", false, 'z');
    2229    document.execCommand("InsertText", false, 'z');
    2330    document.execCommand("InsertText", false, ' ');
     31    if (shouldBeMarked == layoutTestController.hasSpellingMarker(0, 2))
     32        log("PASS:" + id);
     33    else
     34        log("FAIL:" + id);
    2435}
    2536
    26 typeInvalidWord('test1_1');
    27 typeInvalidWord('test1_2');
    28 typeInvalidWord('test1_3');
    29 typeInvalidWord('test2_1');
    30 typeInvalidWord('test2_2');
    31 typeInvalidWord('test2_3');
     37testTypingInvalidWord('test1_1', true);
     38testTypingInvalidWord('test1_2', true);
     39testTypingInvalidWord('test1_3', false);
     40testTypingInvalidWord('test2_1', false);
     41testTypingInvalidWord('test2_2', true);
     42testTypingInvalidWord('test2_3', false);
     43
     44if (window.layoutTestController) {
     45    layoutTestController.dumpAsText();
     46    // Cleaning up for expeation text if running on DRT.
     47    document.getElementById("testRoot").style.display = "none";
     48}
    3249</script>
    3350</body>

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r70284 r70295  
    18771877// We don't draw the spelling markers at all in test shell.
    18781878BUG11577 WIN LINUX : editing/spelling/inline_spelling_markers.html = FAIL
    1879 BUG11577 LINUX : editing/spelling/spellcheck-attribute.html = FAIL
     1879BUG11577 WIN LINUX : editing/spelling/spellcheck-attribute.html = FAIL
    18801880BUG11577 WIN LINUX : editing/spelling/spelling-linebreak.html = FAIL
    18811881
Note: See TracChangeset for help on using the changeset viewer.