Changeset 70299 in webkit


Ignore:
Timestamp:
Oct 22, 2010 3:54:23 AM (13 years ago)
Author:
zherczeg@webkit.org
Message:

2010-10-22 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Csaba Osztrogonác.

JSC interpreter regressions after r69940
https://bugs.webkit.org/show_bug.cgi?id=47839

Wrong "if": It should test whether the result exists,
and not the opposite. It is an interpreter bug, hence
the bots does not capture it.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase):
Location:
trunk/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r70290 r70299  
     12010-10-22  Zoltan Herczeg  <zherczeg@webkit.org>
     2
     3        Reviewed by Csaba Osztrogonác.
     4
     5        JSC interpreter regressions after r69940
     6        https://bugs.webkit.org/show_bug.cgi?id=47839
     7
     8        Wrong "if": It should test whether the result exists,
     9        and not the opposite. It is an interpreter bug, hence
     10        the bots does not capture it.
     11
     12        * interpreter/Interpreter.cpp:
     13        (JSC::Interpreter::resolveBase):
     14
    1152010-10-21  Adam Barth  <abarth@webkit.org>
    216
  • trunk/JavaScriptCore/interpreter/Interpreter.cpp

    r70212 r70299  
    284284    Identifier ident = callFrame->codeBlock()->identifier(property);
    285285    JSValue result = JSC::resolveBase(callFrame, ident, callFrame->scopeChain(), isStrictPut);
    286     if (!result) {
     286    if (result) {
    287287        callFrame->r(dst) = result;
    288288        ASSERT(callFrame->r(dst).jsValue());
Note: See TracChangeset for help on using the changeset viewer.