Changeset 70302 in webkit


Ignore:
Timestamp:
Oct 22, 2010 6:13:24 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70301.
​http://trac.webkit.org/changeset/70301
​https://bugs.webkit.org/show_bug.cgi?id=48126

"Lang attribute layout tests failing" (Requested by satish on
#webkit).

  • fast/speech/input-text-language-tag-expected.txt: Removed.
  • fast/speech/input-text-language-tag.html: Removed.
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:
  • platform/chromium/test_expectations.txt:

2010-10-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70301.
​http://trac.webkit.org/changeset/70301
​https://bugs.webkit.org/show_bug.cgi?id=48126

"Lang attribute layout tests failing" (Requested by satish on
#webkit).

  • dom/Element.cpp: (WebCore::Element::computeInheritedLanguage):
  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-10-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70301.
​http://trac.webkit.org/changeset/70301
​https://bugs.webkit.org/show_bug.cgi?id=48126

"Lang attribute layout tests failing" (Requested by satish on
#webkit).

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
  • public/WebSpeechInputControllerMock.h:
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:

2010-10-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70301.
​http://trac.webkit.org/changeset/70301
​https://bugs.webkit.org/show_bug.cgi?id=48126

"Lang attribute layout tests failing" (Requested by satish on
#webkit).

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult):
Location:
trunk
Files:
2 deleted
31 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r70301 r70302  
     12010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r70301.
     4        http://trac.webkit.org/changeset/70301
     5        https://bugs.webkit.org/show_bug.cgi?id=48126
     6
     7        "Lang attribute layout tests failing" (Requested by satish on
     8        #webkit).
     9
     10        * fast/speech/input-text-language-tag-expected.txt: Removed.
     11        * fast/speech/input-text-language-tag.html: Removed.
     12        * fast/speech/input-text-speechbutton.html:
     13        * fast/speech/speech-button-ignore-generated-events.html:
     14        * platform/chromium/test_expectations.txt:
     15
    1162010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
    217

  • trunk/LayoutTests/fast/speech/input-text-speechbutton.html

    r70301 r70302  
    3333function run() {
    3434    if (window.layoutTestController && window.eventSender) {
    35         layoutTestController.setMockSpeechInputResult('Pictures of the moon', '');
     35        layoutTestController.setMockSpeechInputResult('Pictures of the moon');
    3636
    3737        // Clicking the speech button should fill in mock speech-recognized text.

  • trunk/LayoutTests/fast/speech/speech-button-ignore-generated-events.html

    r70301 r70302  
    5050    if (window.layoutTestController && window.eventSender) {
    5151        // Running in DRT, test the eventSender case.
    52         layoutTestController.setMockSpeechInputResult('Pictures of the moon', '');
     52        layoutTestController.setMockSpeechInputResult('Pictures of the moon');
    5353        document.getElementById('speechInput').onwebkitspeechchange = function() {
    5454            shouldBeEqualToString('document.getElementById("speechInput").value', 'Pictures of the moon');

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r70301 r70302  
    32493249// Added in WebKit r70190
    32503250BUGWK48034 : plugins/pass-different-npp-struct.html = TEXT
    3251 
    32523251// Added in WebKit r70265
    32533252BUGWK48034 : platform/win/plugins/npn-invalidate-rect-invalidates-window.html = TEXT
    3254 
    3255 // Temporarily disabled for a 4-sided patch. Will be enabled again by BUGWK47420.
    3256 BUGWK47089 : fast/speech/input-text-language-tag.html = FAIL

  • trunk/WebCore/ChangeLog

    r70301 r70302  
     12010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r70301.
     4        http://trac.webkit.org/changeset/70301
     5        https://bugs.webkit.org/show_bug.cgi?id=48126
     6
     7        "Lang attribute layout tests failing" (Requested by satish on
     8        #webkit).
     9
     10        * dom/Element.cpp:
     11        (WebCore::Element::computeInheritedLanguage):
     12        * page/SpeechInput.cpp:
     13        (WebCore::SpeechInput::startRecognition):
     14        * page/SpeechInput.h:
     15        * page/SpeechInputClient.h:
     16        * platform/mock/SpeechInputClientMock.cpp:
     17        (WebCore::SpeechInputClientMock::startRecognition):
     18        (WebCore::SpeechInputClientMock::setRecognitionResult):
     19        (WebCore::SpeechInputClientMock::timerFired):
     20        * platform/mock/SpeechInputClientMock.h:
     21        * rendering/TextControlInnerElements.cpp:
     22        (WebCore::TextControlInnerElement::attachInnerElement):
     23        (WebCore::SearchFieldCancelButtonElement::detach):
     24        (WebCore::SpinButtonElement::defaultEventHandler):
     25        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
     26        (WebCore::InputFieldSpeechButtonElement::detach):
     27
    1282010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
    229

  • trunk/WebCore/dom/Element.cpp

    r70301 r70302  
    5757#include "TextIterator.h"
    5858#include "XMLNames.h"
    59 #include <wtf/ASCIICType.h>
    6059#include <wtf/text/CString.h>
    6160
    … …  
    14761475    }
    14771476
    1478     if (!value.isNull() && !value.isEmpty()) {
    1479         // Only A-Za-z0-9 and '-' are allowed in the language tag (see BCP 47)
    1480         const char *p = value.string().ascii().data();
    1481         for (; *p != '\0'; ++p) {
    1482             if (!isASCIIAlphanumeric(*p) && *p != '-')
    1483                 return AtomicString();
    1484         }
    1485     }
    1486 
    14871477    return value;
    14881478}

  • trunk/WebCore/page/SpeechInput.cpp

    r70301 r70302  
    9494}
    9595
    96 bool SpeechInput::startRecognition(int listenerId, const String& language, const IntRect& elementRect)
     96bool SpeechInput::startRecognition(int listenerId, const IntRect& elementRect)
    9797{
    9898    ASSERT(m_listeners.contains(listenerId));
    99     return m_client->startRecognition(listenerId, language, elementRect);
     99    return m_client->startRecognition(listenerId, elementRect);
    100100}
    101101

  • trunk/WebCore/page/SpeechInput.h

    r70301 r70302  
    6262
    6363    // Methods invoked by the input elements.
    64     bool startRecognition(int, const String&, const IntRect&);
     64    bool startRecognition(int, const IntRect&);
    6565    void stopRecording(int);
    6666    void cancelRecognition(int);

  • trunk/WebCore/page/SpeechInputClient.h

    r70301 r70302  
    3232#define SpeechInputClient_h
    3333
    34 #include <wtf/Forward.h>
    35 
    3634#if ENABLE(INPUT_SPEECH)
    3735
    … …  
    5149
    5250    // Starts speech recognition and audio recording.
    53     virtual bool startRecognition(int requestId, const String& language, const IntRect& elementRect) = 0;
     51    virtual bool startRecognition(int requestId, const IntRect& elementRect) = 0;
    5452
    5553    // Stops audio recording and performs recognition with the audio recorded until now

  • trunk/WebCore/platform/mock/SpeechInputClientMock.cpp

    r70301 r70302  
    3636#include "SpeechInputListener.h"
    3737
    38 namespace {
    39     // HashMap doesn't support empty strings as keys, so this value (an invalid BCP47 tag) is used for those cases.
    40     const String emptyLanguage = "_";
    41 }
    42 
    4338namespace WebCore {
    4439
    … …  
    5651}
    5752
    58 bool SpeechInputClientMock::startRecognition(int requestId, const String& language, const IntRect&)
     53bool SpeechInputClientMock::startRecognition(int requestId, const IntRect&)
    5954{
    6055    if (m_timer.isActive())
    … …  
    6257    m_requestId = requestId;
    6358    m_recording = true;
    64     m_language = language;
    6559    m_timer.startOneShot(0);
    6660    return true;
    … …  
    8781}
    8882
    89 void SpeechInputClientMock::setRecognitionResult(const String& result, const String& language)
     83void SpeechInputClientMock::setRecognitionResult(const String& result)
    9084{
    91     if (language.isEmpty())
    92         m_recognitionResult.set(emptyLanguage, result);
    93     else
    94         m_recognitionResult.set(language, result);
     85    m_recognitionResult = result;
    9586}
    9687
    … …  
    10293        m_timer.startOneShot(0);
    10394    } else {
    104         String language = m_language.isEmpty() ? String(emptyLanguage) : m_language;
    105         if (!m_recognitionResult.contains(language)) {
    106             // Can't avoid setting a result on empty or invalid language strings.
    107             // This would avoid generating the events used to check the results and the test would timeout.
    108             String error("error: no result found for language '");
    109             error.append(m_language);
    110             error.append("'");
    111             m_listener->setRecognitionResult(m_requestId, error);
    112         } else
    113             m_listener->setRecognitionResult(m_requestId, m_recognitionResult.get(language));
    114 
     95        m_listener->setRecognitionResult(m_requestId, m_recognitionResult);
    11596        m_listener->didCompleteRecognition(m_requestId);
    11697        m_requestId = 0;

  • trunk/WebCore/platform/mock/SpeechInputClientMock.h

    r70301 r70302  
    3535#include "SpeechInputClient.h"
    3636#include "Timer.h"
    37 #include <wtf/HashMap.h>
    38 #include <wtf/text/StringHash.h>
    3937
    4038#if ENABLE(INPUT_SPEECH)
    … …  
    4947    SpeechInputClientMock();
    5048
    51     void setRecognitionResult(const String& result, const String& language);
     49    void setRecognitionResult(const String& result);
    5250
    5351    // SpeechInputClient methods.
    5452    void setListener(SpeechInputListener*);
    55     bool startRecognition(int, const String&, const IntRect&);
     53    bool startRecognition(int, const IntRect&);
    5654    void stopRecording(int);
    5755    void cancelRecognition(int);
    … …  
    6462    SpeechInputListener* m_listener;
    6563    int m_requestId;
    66 
    67     HashMap<String, String> m_recognitionResult;
    68     String m_language;
     64    String m_recognitionResult;
    6965};
    7066

  • trunk/WebCore/rendering/TextControlInnerElements.cpp

    r70301 r70302  
    2222 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
    2323 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
    24  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
    2525 */
    26 
     26 
    2727#include "config.h"
    2828#include "TextControlInnerElements.h"
    … …  
    108108        renderer->setStyle(style);
    109109    }
    110 
     110   
    111111    // Set these explicitly since this normally happens during an attach()
    112112    setAttached();
    113113    setInDocument();
    114 
     114   
    115115    // For elements without a shadow parent, add the node to the DOM normally.
    116116    if (!m_shadowParent) {
    … …  
    119119        parent->deprecatedParserAddChild(this);
    120120    }
    121 
     121 
    122122    // Add the renderer to the render tree
    123123    if (renderer)
    … …  
    209209    if (m_capturing) {
    210210        if (Frame* frame = document()->frame())
    211             frame->eventHandler()->setCapturingMouseEventsNode(0);
     211            frame->eventHandler()->setCapturingMouseEventsNode(0);     
    212212    }
    213213    TextControlInnerElement::detach();
    … …  
    282282        if (!event->defaultHandled())
    283283            HTMLDivElement::defaultEventHandler(event);
    284         return;
    285     }
    286 
     284        return;       
     285    }
     286   
    287287    HTMLInputElement* input = static_cast<HTMLInputElement*>(shadowAncestorNode());
    288288    if (input->disabled() || input->isReadOnlyFormControl()) {
    … …  
    432432        switch (m_state) {
    433433        case Idle:
    434             if (speechInput()->startRecognition(m_listenerId, input->computeInheritedLanguage(), input->renderer()->absoluteBoundingBoxRect()))
     434            if (speechInput()->startRecognition(m_listenerId, input->renderer()->absoluteBoundingBoxRect()))
    435435                setState(Recording);
    436436            break;
    … …  
    488488    if (m_capturing) {
    489489        if (Frame* frame = document()->frame())
    490             frame->eventHandler()->setCapturingMouseEventsNode(0);
     490            frame->eventHandler()->setCapturingMouseEventsNode(0);     
    491491    }
    492492

  • trunk/WebKit/chromium/ChangeLog

    r70301 r70302  
     12010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r70301.
     4        http://trac.webkit.org/changeset/70301
     5        https://bugs.webkit.org/show_bug.cgi?id=48126
     6
     7        "Lang attribute layout tests failing" (Requested by satish on
     8        #webkit).
     9
     10        * public/WebSpeechInputController.h:
     11        (WebKit::WebSpeechInputController::startRecognition):
     12        * public/WebSpeechInputControllerMock.h:
     13        * src/SpeechInputClientImpl.cpp:
     14        (WebKit::SpeechInputClientImpl::startRecognition):
     15        * src/SpeechInputClientImpl.h:
     16        * src/WebSpeechInputControllerMockImpl.cpp:
     17        (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult):
     18        (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
     19        * src/WebSpeechInputControllerMockImpl.h:
     20        * src/WebViewImpl.cpp:
     21        (WebKit::WebViewImpl::WebViewImpl):
     22        * src/WebViewImpl.h:
     23
    1242010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
    225

  • trunk/WebKit/chromium/public/WebSpeechInputController.h

    r70301 r70302  
    3636namespace WebKit {
    3737
    38 class WebString;
    3938struct WebRect;
    4039
    … …  
    4544    // runs to the limit or stopRecording is called. Progress indications and the recognized
    4645    // text are returned via the listener interface.
    47     virtual bool startRecognition(int requestId, const WebString& language, const WebRect& elementRect)
     46    virtual bool startRecognition(int requestId, const WebRect&)
    4847    {
    4948        WEBKIT_ASSERT_NOT_REACHED();

  • trunk/WebKit/chromium/public/WebSpeechInputControllerMock.h

    r70301 r70302  
    4545    virtual ~WebSpeechInputControllerMock() { }
    4646
    47     virtual void setMockRecognitionResult(const WebString& result, const WebString& language) = 0;
    48 
    49     // FIXME: this is a fix for a two-sided patch. Delete as soon as the chromium side is patched.
    50     // Chromium patch not uploaded yet, but will depend on http://codereview.chromium.org/3615005/show patch.
    5147    virtual void setMockRecognitionResult(const WebString& result) = 0;
    5248};

  • trunk/WebKit/chromium/src/SpeechInputClientImpl.cpp

    r70301 r70302  
    3333
    3434#include "PlatformString.h"
    35 #include "SpeechInputListener.h"
    3635#include "WebSpeechInputController.h"
    3736#include "WebString.h"
    3837#include "WebViewClient.h"
    39 #include <wtf/PassOwnPtr.h>
     38#include "page/SpeechInputListener.h"
    4039
    4140#if ENABLE(INPUT_SPEECH)
    4241
    4342namespace WebKit {
    44 
    45 PassOwnPtr<SpeechInputClientImpl> SpeechInputClientImpl::create(WebViewClient* client)
    46 {
    47     return adoptPtr(new SpeechInputClientImpl(client));
    48 }
    4943
    5044SpeechInputClientImpl::SpeechInputClientImpl(WebViewClient* web_view_client)
    … …  
    6357}
    6458
    65 bool SpeechInputClientImpl::startRecognition(int requestId, const String& language, const WebCore::IntRect& elementRect)
     59bool SpeechInputClientImpl::startRecognition(int requestId, const WebCore::IntRect& elementRect)
    6660{
    6761    ASSERT(m_listener);
    68     return m_controller->startRecognition(requestId, language, elementRect);
     62    return m_controller->startRecognition(requestId, elementRect);
    6963}
    7064

  • trunk/WebKit/chromium/src/SpeechInputClientImpl.h

    r70301 r70302  
    3434#if ENABLE(INPUT_SPEECH)
    3535
    36 #include "SpeechInputClient.h"
    3736#include "WebSpeechInputListener.h"
    38 #include <wtf/Forward.h>
    39 #include <wtf/OwnPtr.h>
    40 #include <wtf/PassOwnPtr.h>
    41 
    42 namespace WTF {
    43 class String;
    44 }
     37#include "page/SpeechInputClient.h"
    4538
    4639namespace WebCore {
    … …  
    5750      public WebSpeechInputListener {
    5851public:
    59     static PassOwnPtr<SpeechInputClientImpl> create(WebViewClient*);
     52    SpeechInputClientImpl(WebViewClient*);
    6053    virtual ~SpeechInputClientImpl();
    6154
    6255    // SpeechInputClient methods.
    6356    void setListener(WebCore::SpeechInputListener*);
    64     bool startRecognition(int, const String&, const WebCore::IntRect&);
     57    bool startRecognition(int, const WebCore::IntRect&);
    6558    void stopRecording(int);
    6659    void cancelRecognition(int);
    … …  
    7265
    7366private:
    74     SpeechInputClientImpl(WebViewClient*);
    75 
    7667    WebSpeechInputController* m_controller; // To call into the embedder.
    7768    WebCore::SpeechInputListener* m_listener;

  • trunk/WebKit/chromium/src/WebSpeechInputControllerMockImpl.cpp

    r70301 r70302  
    5858void WebSpeechInputControllerMockImpl::setMockRecognitionResult(const WebString& result)
    5959{
    60     m_webcoreMock->setRecognitionResult(result, WebString::fromUTF8(""));
    61 }
    62 
    63 void WebSpeechInputControllerMockImpl::setMockRecognitionResult(const WebString& result, const WebString &language)
    64 {
    65     m_webcoreMock->setRecognitionResult(result, language);
     60    m_webcoreMock->setRecognitionResult(result);
    6661}
    6762
    … …  
    8176}
    8277
    83 bool WebSpeechInputControllerMockImpl::startRecognition(int requestId, const WebString& language, const WebRect& elementRect)
     78bool WebSpeechInputControllerMockImpl::startRecognition(int requestId, const WebRect& elementRect)
    8479{
    85     return m_webcoreMock->startRecognition(requestId, language, elementRect);
     80    return m_webcoreMock->startRecognition(requestId, elementRect);
    8681}
    8782

  • trunk/WebKit/chromium/src/WebSpeechInputControllerMockImpl.h

    r70301 r70302  
    3838#include <wtf/OwnPtr.h>
    3939
    40 namespace WTF {
    41 class String;
    42 }
    43 
    4440namespace WebCore {
    4541class SpeechInputClientMock;
    … …  
    6258
    6359    // WebSpeechInputController methods.
    64     bool startRecognition(int requestId, const WebString& language, const WebRect& elementRect);
     60    bool startRecognition(int requestId, const WebRect& elementRect);
    6561    void cancelRecognition(int requestId);
    6662    void stopRecording(int requestId);
    6763
    6864    // WebSpeechInputControllerMock methods.
    69     void setMockRecognitionResult(const WebString& result, const WebString& language);
    70 
    71     // FIXME: this is a fix for a two-sided patch. Delete as soon as the chromium side is patched.
    72     // Chromium patch not uploaded yet, but will depend on http://codereview.chromium.org/3615005/show patch.
    7365    void setMockRecognitionResult(const WebString& result);
    7466
    … …  
    8173
    8274#endif // WebSpeechInputControllerMockImpl_h
     75

  • trunk/WebKit/chromium/src/WebViewImpl.cpp

    r70301 r70302  
    8989#include "SelectionController.h"
    9090#include "Settings.h"
    91 #include "SpeechInputClientImpl.h"
    9291#include "Timer.h"
    9392#include "TypingCommand.h"
    … …  
    284283#endif
    285284#if ENABLE(INPUT_SPEECH)
    286     , m_speechInputClient(SpeechInputClientImpl::create(client))
     285    , m_speechInputClient(client)
    287286#endif
    288287    , m_deviceOrientationClientProxy(new DeviceOrientationClientProxy(client ? client->deviceOrientationClient() : 0))
    … …  
    307306    pageClients.inspectorClient = &m_inspectorClientImpl;
    308307#if ENABLE(INPUT_SPEECH)
    309     pageClients.speechInputClient = m_speechInputClient.get();
     308    pageClients.speechInputClient = &m_speechInputClient;
    310309#endif
    311310    pageClients.deviceOrientationClient = m_deviceOrientationClientProxy.get();

  • trunk/WebKit/chromium/src/WebViewImpl.h

    r70301 r70302  
    5050#include "LayerRendererChromium.h"
    5151#include "NotificationPresenterImpl.h"
     52#include "SpeechInputClientImpl.h"
    5253#include <wtf/OwnPtr.h>
    5354#include <wtf/RefCounted.h>
    … …  
    7475class DeviceOrientationClientProxy;
    7576class DragScrollTimer;
    76 class SpeechInputClientImpl;
    7777class WebAccessibilityObject;
    7878class WebDevToolsAgentClient;
    … …  
    548548
    549549#if ENABLE(INPUT_SPEECH)
    550     OwnPtr<SpeechInputClientImpl> m_speechInputClient;
     550    SpeechInputClientImpl m_speechInputClient;
    551551#endif
    552552    // If we attempt to fetch the on-screen GraphicsContext3D before

  • trunk/WebKitTools/ChangeLog

    r70301 r70302  
     12010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r70301.
     4        http://trac.webkit.org/changeset/70301
     5        https://bugs.webkit.org/show_bug.cgi?id=48126
     6
     7        "Lang attribute layout tests failing" (Requested by satish on
     8        #webkit).
     9
     10        * DumpRenderTree/LayoutTestController.cpp:
     11        (setMockSpeechInputResultCallback):
     12        * DumpRenderTree/LayoutTestController.h:
     13        * DumpRenderTree/chromium/LayoutTestController.cpp:
     14        (LayoutTestController::setMockSpeechInputResult):
     15        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     16        (LayoutTestController::setMockSpeechInputResult):
     17        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
     18        (LayoutTestController::setMockSpeechInputResult):
     19        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
     20        (LayoutTestController::setMockSpeechInputResult):
     21        * DumpRenderTree/qt/LayoutTestControllerQt.h:
     22        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
     23        (LayoutTestController::setMockSpeechInputResult):
     24        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
     25        (LayoutTestController::setMockSpeechInputResult):
     26
    1272010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
    228

  • trunk/WebKitTools/DumpRenderTree/LayoutTestController.cpp

    r70301 r70302  
    10711071static JSValueRef setMockSpeechInputResultCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
    10721072{
    1073     if (argumentCount < 2)
     1073    if (argumentCount < 1)
    10741074        return JSValueMakeUndefined(context);
    10751075
    … …  
    10771077    ASSERT(!*exception);
    10781078
    1079     JSRetainPtr<JSStringRef> language(Adopt, JSValueToStringCopy(context, arguments[1], exception));
    1080     ASSERT(!*exception);
    1081 
    1082     LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject));
    1083     controller->setMockSpeechInputResult(result.get(), language.get());
     1079    LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject));
     1080    controller->setMockSpeechInputResult(result.get());
    10841081
    10851082    return JSValueMakeUndefined(context);

  • trunk/WebKitTools/DumpRenderTree/LayoutTestController.h

    r70301 r70302  
    9595    void setMockGeolocationError(int code, JSStringRef message);
    9696    void setMockGeolocationPosition(double latitude, double longitude, double accuracy);
    97     void setMockSpeechInputResult(JSStringRef result, JSStringRef language);
     97    void setMockSpeechInputResult(JSStringRef result);
    9898    void setPersistentUserStyleSheetLocation(JSStringRef path);
    9999    void setPluginsEnabled(bool flag);

  • trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp

    r70301 r70302  
    15271527{
    15281528    result->setNull();
    1529     if (arguments.size() < 2 || !arguments[0].isString() || !arguments[1].isString())
    1530         return;
    1531 
    1532     m_speechInputControllerMock->setMockRecognitionResult(cppVariantToWebString(arguments[0]), cppVariantToWebString(arguments[1]));
     1529    if (arguments.size() < 1 || !arguments[0].isString())
     1530        return;
     1531
     1532    m_speechInputControllerMock->setMockRecognitionResult(cppVariantToWebString(arguments[0]));
    15331533}
    15341534

  • trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r70301 r70302  
    501501}
    502502
    503 void LayoutTestController::setMockSpeechInputResult(JSStringRef result, JSStringRef language)
     503void LayoutTestController::setMockSpeechInputResult(JSStringRef result)
    504504{
    505505    // FIXME: Implement for speech input layout tests.

  • trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm

    r70301 r70302  
    372372}
    373373
    374 void LayoutTestController::setMockSpeechInputResult(JSStringRef result, JSStringRef language)
     374void LayoutTestController::setMockSpeechInputResult(JSStringRef result)
    375375{
    376376    // FIXME: Implement for speech input layout tests.

  • trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

    r70301 r70302  
    760760}
    761761
    762 void LayoutTestController::setMockSpeechInputResult(const QString& result, const QString& language)
     762void LayoutTestController::setMockSpeechInputResult(const QString& result)
    763763{
    764764    // FIXME: Implement for speech input layout tests.

  • trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h

    r70301 r70302  
    216216    bool geolocationPermission() const { return m_geolocationPermission; }
    217217
    218     void setMockSpeechInputResult(const QString& result, const QString& language);
     218    void setMockSpeechInputResult(const QString& result);
    219219
    220220    // Empty stub method to keep parity with object model exposed by global LayoutTestController.

  • trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp

    r70301 r70302  
    406406}
    407407
    408 void LayoutTestController::setMockSpeechInputResult(JSStringRef result, JSStringRef language)
     408void LayoutTestController::setMockSpeechInputResult(JSStringRef result)
    409409{
    410410    // FIXME: Implement for speech input layout tests.

  • trunk/WebKitTools/DumpRenderTree/wx/LayoutTestControllerWx.cpp

    r70301 r70302  
    321321}
    322322
    323 void LayoutTestController::setMockSpeechInputResult(JSStringRef result, JSStringRef language)
     323void LayoutTestController::setMockSpeechInputResult(JSStringRef result)
    324324{
    325325    // FIXME: Implement for speech input layout tests.
    … …  
    529529    return 0;
    530530}
     531
Note: See TracChangeset for help on using the changeset viewer.