Changeset 70323 in webkit

Timestamp:

Oct 22, 2010 12:00:36 PM (14 years ago)

Author:

krit@webkit.org

Message:

2010-10-22 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Dirk Schulze.

getBoundingClientRect does not work with SVG <text>
​https://bugs.webkit.org/show_bug.cgi?id=46775

Added back to SVGStyledTransformableElement overloads of the following
methods: nearestViewportElement, farthestViewportElement, getBBox.
This was necessary to appease the Visual C++ compiler, which warned on
inheritance via dominance.

• svg/SVGStyledTransformableElement.cpp:
• svg/SVGStyledTransformableElement.h: (SVGStyledTransformableElement::nearestViewportElement): (SVGStyledTransformableElement::farthestViewportElement): (SVGStyledTransformableElement::getBBox):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/SVGStyledTransformableElement.cpp (modified) (1 diff)
• svg/SVGStyledTransformableElement.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-22  Cosmin Truta  <ctruta@chromium.org>
+
+        Reviewed by Dirk Schulze.
+
+        getBoundingClientRect does not work with SVG <text>
+        https://bugs.webkit.org/show_bug.cgi?id=46775
+
+        Added back to SVGStyledTransformableElement overloads of the following
+        methods: nearestViewportElement, farthestViewportElement, getBBox.
+        This was necessary to appease the Visual C++ compiler, which warned on
+        inheritance via dominance.
+
+        * svg/SVGStyledTransformableElement.cpp:
+        * svg/SVGStyledTransformableElement.h:
+        (SVGStyledTransformableElement::nearestViewportElement):
+        (SVGStyledTransformableElement::farthestViewportElement):
+        (SVGStyledTransformableElement::getBBox):
+
 2010-10-21  Chris Marrin  <cmarrin@apple.com>
 

trunk/WebCore/svg/SVGStyledTransformableElement.cpp

@@ -91 +91 @@
 }
 
+SVGElement* SVGStyledTransformableElement::nearestViewportElement() const
+{
+    return SVGTransformable::nearestViewportElement(this);
+}
+
+SVGElement* SVGStyledTransformableElement::farthestViewportElement() const
+{
+    return SVGTransformable::farthestViewportElement(this);
+}
+
+FloatRect SVGStyledTransformableElement::getBBox(StyleUpdateStrategy styleUpdateStrategy) const
+{
+    return SVGTransformable::getBBox(this, styleUpdateStrategy);
+}
+
 RenderObject* SVGStyledTransformableElement::createRenderer(RenderArena* arena, RenderStyle*)
 {

trunk/WebCore/svg/SVGStyledTransformableElement.h

@@ -38 +38 @@
     virtual AffineTransform getCTM(StyleUpdateStrategy = AllowStyleUpdate) const;
     virtual AffineTransform getScreenCTM(StyleUpdateStrategy = AllowStyleUpdate) const;
+    virtual SVGElement* nearestViewportElement() const;
+    virtual SVGElement* farthestViewportElement() const;
 
     virtual AffineTransform localCoordinateSpaceTransform(SVGLocatable::CTMScope mode) const { return SVGTransformable::localCoordinateSpaceTransform(mode); }
     virtual AffineTransform animatedLocalTransform() const;
     virtual AffineTransform* supplementalTransform();
+
+    virtual FloatRect getBBox(StyleUpdateStrategy = AllowStyleUpdate) const;
 
     bool isKnownAttribute(const QualifiedName&);