Changeset 70329 in webkit

Timestamp:

Oct 22, 2010 1:21:14 PM (14 years ago)

Author:

andersca@apple.com

Message:

Rename processDidExit to processDidCrash
​https://bugs.webkit.org/show_bug.cgi?id=48146

Reviewed by Sam Weinig.

• UIProcess/API/C/WKPage.h:
• UIProcess/API/mac/PageClientImpl.h:
• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::processDidCrash):

• UIProcess/API/mac/WKView.mm:

(-[WKView _processDidCrash]):

• UIProcess/API/mac/WKViewInternal.h:
• UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

• UIProcess/API/qt/qwkpage_p.h:

(QWKPagePrivate::processDidCrash):

• UIProcess/PageClient.h:
• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit::WebLoaderClient::processDidBecomeResponsive):
(WebKit::WebLoaderClient::processDidCrash):

• UIProcess/WebLoaderClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidBecomeUnresponsive):
(WebKit::WebPageProxy::processDidBecomeResponsive):
(WebKit::WebPageProxy::processDidCrash):

• UIProcess/WebPageProxy.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didClose):

• UIProcess/win/WebView.cpp:

(WebKit::WebView::processDidCrash):

• UIProcess/win/WebView.h:

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/C/WKPage.h (modified) (2 diffs)
• UIProcess/API/mac/PageClientImpl.h (modified) (1 diff)
• UIProcess/API/mac/PageClientImpl.mm (modified) (1 diff)
• UIProcess/API/mac/WKView.mm (modified) (1 diff)
• UIProcess/API/mac/WKViewInternal.h (modified) (1 diff)
• UIProcess/API/qt/qwkpage.cpp (modified) (1 diff)
• UIProcess/API/qt/qwkpage_p.h (modified) (1 diff)
• UIProcess/PageClient.h (modified) (1 diff)
• UIProcess/WebLoaderClient.cpp (modified) (1 diff)
• UIProcess/WebLoaderClient.h (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (2 diffs)
• UIProcess/WebPageProxy.h (modified) (1 diff)
• UIProcess/WebProcessProxy.cpp (modified) (1 diff)
• UIProcess/win/WebView.cpp (modified) (1 diff)
• UIProcess/win/WebView.h (modified) (1 diff)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-10-22  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Rename processDidExit to processDidCrash
+        https://bugs.webkit.org/show_bug.cgi?id=48146
+
+        * UIProcess/API/C/WKPage.h:
+        * UIProcess/API/mac/PageClientImpl.h:
+        * UIProcess/API/mac/PageClientImpl.mm:
+        (WebKit::PageClientImpl::processDidCrash):
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView _processDidCrash]):
+        * UIProcess/API/mac/WKViewInternal.h:
+        * UIProcess/API/qt/qwkpage.cpp:
+        (QWKPage::QWKPage):
+        * UIProcess/API/qt/qwkpage_p.h:
+        (QWKPagePrivate::processDidCrash):
+        * UIProcess/PageClient.h:
+        * UIProcess/WebLoaderClient.cpp:
+        (WebKit::WebLoaderClient::processDidBecomeUnresponsive):
+        (WebKit::WebLoaderClient::processDidBecomeResponsive):
+        (WebKit::WebLoaderClient::processDidCrash):
+        * UIProcess/WebLoaderClient.h:
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::processDidBecomeUnresponsive):
+        (WebKit::WebPageProxy::processDidBecomeResponsive):
+        (WebKit::WebPageProxy::processDidCrash):
+        * UIProcess/WebPageProxy.h:
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::didClose):
+        * UIProcess/win/WebView.cpp:
+        (WebKit::WebView::processDidCrash):
+        * UIProcess/win/WebView.h:
+
 2010-10-22  Dan Bernstein  <mitz@apple.com>
 

trunk/WebKit2/UIProcess/API/C/WKPage.h

@@ -70 +70 @@
 // WebPageNamespace Client
 // FIXME: These three functions should not be part of this client.
-typedef void (*WKPageDidBecomeUnresponsiveCallback)(WKPageRef page, const void *clientInfo);
-typedef void (*WKPageDidBecomeResponsiveCallback)(WKPageRef page, const void *clientInfo);
-typedef void (*WKPageProcessDidExitCallback)(WKPageRef page, const void *clientInfo);
+typedef void (*WKPageProcessDidBecomeUnresponsiveCallback)(WKPageRef page, const void *clientInfo);
+typedef void (*WKPageProcessDidBecomeResponsiveCallback)(WKPageRef page, const void *clientInfo);
+typedef void (*WKPageProcessDidCrashCallback)(WKPageRef page, const void *clientInfo);
 
 typedef void (*WKPageDidChangeBackForwardListCallback)(WKPageRef page, const void *clientInfo);
@@ -97 +97 @@
 
     // FIXME: These three functions should not be part of this client.
-    WKPageDidBecomeUnresponsiveCallback                                 didBecomeUnresponsive;
-    WKPageDidBecomeResponsiveCallback                                   didBecomeResponsive;
-    WKPageProcessDidExitCallback                                        processDidExit;
+    WKPageProcessDidBecomeUnresponsiveCallback                          processDidBecomeUnresponsive;
+    WKPageProcessDidBecomeResponsiveCallback                            processDidBecomeResponsive;
+    WKPageProcessDidCrashCallback                                       processDidCrash;
 
     WKPageDidChangeBackForwardListCallback                              didChangeBackForwardList;

trunk/WebKit2/UIProcess/API/mac/PageClientImpl.h

@@ -49 +49 @@
     PageClientImpl(WKView*);
 
-    virtual void processDidExit();
+    virtual void processDidCrash();
     virtual void processDidRevive();
     virtual void takeFocus(bool direction);

trunk/WebKit2/UIProcess/API/mac/PageClientImpl.mm

@@ -115 +115 @@
 }
 
-void PageClientImpl::processDidExit()
-{
-    [m_wkView _processDidExit];
+void PageClientImpl::processDidCrash()
+{
+    [m_wkView _processDidCrash];
 }
 

trunk/WebKit2/UIProcess/API/mac/WKView.mm

@@ -502 +502 @@
 @implementation WKView (Internal)
 
-- (void)_processDidExit
+- (void)_processDidCrash
 {
     [self setNeedsDisplay:YES];

trunk/WebKit2/UIProcess/API/mac/WKViewInternal.h

@@ -31 +31 @@
 
 @interface WKView (Internal)
-- (void)_processDidExit;
+- (void)_processDidCrash;
 - (void)_processDidRevive;
 - (void)_takeFocus:(BOOL)direction;

trunk/WebKit2/UIProcess/API/qt/qwkpage.cpp

@@ -290 +290 @@
         qt_wk_didBecomeUnresponsive,
         qt_wk_didBecomeResponsive,
-        0,  /* processDidExit */
+        0,  /* processDidCrash */
         0   /* didChangeBackForwardList */
     };

trunk/WebKit2/UIProcess/API/qt/qwkpage_p.h

@@ -49 +49 @@
     void pageDidLeaveAcceleratedCompositing() { }
 #endif // USE(ACCELERATED_COMPOSITING)
-    virtual void processDidExit() { }
+    virtual void processDidCrash() { }
     virtual void processDidRevive() { }
     virtual void setCursor(const WebCore::Cursor&);

trunk/WebKit2/UIProcess/PageClient.h

@@ -47 +47 @@
     virtual ~PageClient() { }
 
-    virtual void processDidExit() = 0;
+    virtual void processDidCrash() = 0;
     virtual void processDidRevive() = 0;
 

trunk/WebKit2/UIProcess/WebLoaderClient.cpp

@@ -158 +158 @@
 }
 
-void WebLoaderClient::didBecomeUnresponsive(WebPageProxy* page)
+void WebLoaderClient::processDidBecomeUnresponsive(WebPageProxy* page)
 {
-    if (!m_pageLoaderClient.didBecomeUnresponsive)
+    if (!m_pageLoaderClient.processDidBecomeUnresponsive)
         return;
 
-    m_pageLoaderClient.didBecomeUnresponsive(toAPI(page), m_pageLoaderClient.clientInfo);
+    m_pageLoaderClient.processDidBecomeUnresponsive(toAPI(page), m_pageLoaderClient.clientInfo);
 }
 
-void WebLoaderClient::didBecomeResponsive(WebPageProxy* page)
+void WebLoaderClient::processDidBecomeResponsive(WebPageProxy* page)
 {
-    if (!m_pageLoaderClient.didBecomeResponsive)
+    if (!m_pageLoaderClient.processDidBecomeResponsive)
         return;
 
-    m_pageLoaderClient.didBecomeResponsive(toAPI(page), m_pageLoaderClient.clientInfo);
+    m_pageLoaderClient.processDidBecomeResponsive(toAPI(page), m_pageLoaderClient.clientInfo);
 }
 
-void WebLoaderClient::processDidExit(WebPageProxy* page)
+void WebLoaderClient::processDidCrash(WebPageProxy* page)
 {
-    if (!m_pageLoaderClient.processDidExit)
+    if (!m_pageLoaderClient.processDidCrash)
         return;
 
-    m_pageLoaderClient.processDidExit(toAPI(page), m_pageLoaderClient.clientInfo);
+    m_pageLoaderClient.processDidCrash(toAPI(page), m_pageLoaderClient.clientInfo);
 }
 

trunk/WebKit2/UIProcess/WebLoaderClient.h

@@ -62 +62 @@
 
     // FIXME: These three functions should not be part of this client.
-    void didBecomeUnresponsive(WebPageProxy*);
-    void didBecomeResponsive(WebPageProxy*);
-    void processDidExit(WebPageProxy*);
+    void processDidBecomeUnresponsive(WebPageProxy*);
+    void processDidBecomeResponsive(WebPageProxy*);
+    void processDidCrash(WebPageProxy*);
 
     void didChangeBackForwardList(WebPageProxy*);

trunk/WebKit2/UIProcess/WebPageProxy.cpp

@@ -1140 +1140 @@
 void WebPageProxy::processDidBecomeUnresponsive()
 {
-    m_loaderClient.didBecomeUnresponsive(this);
+    m_loaderClient.processDidBecomeUnresponsive(this);
 }
 
 void WebPageProxy::processDidBecomeResponsive()
 {
-    m_loaderClient.didBecomeResponsive(this);
-}
-
-void WebPageProxy::processDidExit()
+    m_loaderClient.processDidBecomeResponsive(this);
+}
+
+void WebPageProxy::processDidCrash()
 {
     ASSERT(m_pageClient);
@@ -1191 +1191 @@
     m_estimatedProgress = 0.0;
 
-    m_pageClient->processDidExit();
-    m_loaderClient.processDidExit(this);
+    m_pageClient->processDidCrash();
+    m_loaderClient.processDidCrash(this);
 }
 

trunk/WebKit2/UIProcess/WebPageProxy.h

@@ -196 +196 @@
     void processDidBecomeUnresponsive();
     void processDidBecomeResponsive();
-    void processDidExit();
+    void processDidCrash();
     void processDidRevive();
 

trunk/WebKit2/UIProcess/WebProcessProxy.cpp

@@ -413 +413 @@
 
     for (size_t i = 0, size = pages.size(); i < size; ++i)
-        pages[i]->processDidExit();
+        pages[i]->processDidCrash();
 
     // This may cause us to be deleted.

trunk/WebKit2/UIProcess/win/WebView.cpp

@@ -538 +538 @@
 // PageClient
 
-void WebView::processDidExit()
+void WebView::processDidCrash()
 {
 }

trunk/WebKit2/UIProcess/win/WebView.h

@@ -93 +93 @@
 
     // PageClient
-    virtual void processDidExit();
+    virtual void processDidCrash();
     virtual void processDidRevive();
     virtual void takeFocus(bool direction);