Changeset 70376 in webkit


Ignore:
Timestamp:
Oct 22, 2010 5:48:02 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-22 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Adam Roben.

Windows client needs updating when live iframe element is moved between pages
​https://bugs.webkit.org/show_bug.cgi?id=46915

  • platform/win/Skipped: Stop skipping fast/frames/iframe-reparenting-adopt-node.html

2010-10-22 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Adam Roben.

Windows client needs updating when live iframe element is moved between pages
​https://bugs.webkit.org/show_bug.cgi?id=46915

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didTransferChildFrameToNewDocument): Update WebView in WebFrame to match that of the current page.
  • WebFrame.cpp: (WebFrame::setWebView): Added.
  • WebFrame.h:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r70372 r70376  
     12010-10-22  Jenn Braithwaite  <jennb@chromium.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        Windows client needs updating when live iframe element is moved between pages
     6        https://bugs.webkit.org/show_bug.cgi?id=46915
     7
     8        * platform/win/Skipped:
     9        Stop skipping fast/frames/iframe-reparenting-adopt-node.html
     10
    1112010-10-22  Abhishek Arya  <inferno@chromium.org>
    212

  • trunk/LayoutTests/platform/win/Skipped

    r70367 r70376  
    298298# and https://bugs.webkit.org/show_bug.cgi?id=45021
    299299media/context-menu-actions.html
    300 
    301 # https://bugs.webkit.org/show_bug.cgi?id=44713
    302 fast/frames/iframe-reparenting-adopt-node.html
    303300
    304301# Assertion failure in replaySavedEvents http://webkit.org/b/21796

  • trunk/WebKit/win/ChangeLog

    r70341 r70376  
     12010-10-22  Jenn Braithwaite  <jennb@chromium.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        Windows client needs updating when live iframe element is moved between pages
     6        https://bugs.webkit.org/show_bug.cgi?id=46915
     7
     8        * WebCoreSupport/WebFrameLoaderClient.cpp:
     9        (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
     10        Update WebView in WebFrame to match that of the current page.
     11        * WebFrame.cpp:
     12        (WebFrame::setWebView):
     13        Added.
     14        * WebFrame.h:
     15
    1162010-10-22  Sam Weinig  <sam@webkit.org>
    217

  • trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

    r70333 r70376  
    731731void WebFrameLoaderClient::didTransferChildFrameToNewDocument(Page*)
    732732{
     733    Frame* coreFrame = core(m_webFrame);
     734    ASSERT(coreFrame);
     735    WebView* webView = kit(coreFrame->page());
     736    if (m_webFrame->webView() != webView)
     737        m_webFrame->setWebView(webView);
    733738}
    734739

  • trunk/WebKit/win/WebFrame.cpp

    r70291 r70376  
    25872587}
    25882588
     2589void WebFrame::setWebView(WebView* webView)
     2590{
     2591    d->webView = webView;
     2592}
     2593
    25892594COMPtr<IAccessible> WebFrame::accessible() const
    25902595{

  • trunk/WebKit/win/WebFrame.h

    r70291 r70376  
    377377
    378378    WebView* webView() const;
     379    void setWebView(WebView*);
    379380
    380381    COMPtr<IAccessible> accessible() const;
Note: See TracChangeset for help on using the changeset viewer.