Changeset 70420 in webkit

Timestamp:

Oct 24, 2010 11:58:02 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2010-10-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: polish network panel UI.
​https://bugs.webkit.org/show_bug.cgi?id=48205

• inspector/front-end/Images/frame.png:
• inspector/front-end/Images/networkIcon.png:
• inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkPanel.prototype._toggleGridMode):
• inspector/front-end/networkPanel.css: (.network.panel .data-grid td): (.network.panel .data-grid.small td): (#network-views .resource-view.headers-visible .resource-view-content): (#network-views.small .resource-view.headers-visible .resource-view-content): (#network-views .resource-view-headers): (#network-views.small .resource-view-headers): (#network-views .resource-view .tabbed-pane-header): (#network-views.small .resource-view .tabbed-pane-header):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/Images/frame.png (modified) (previous)
• inspector/front-end/Images/networkIcon.png (modified) (previous)
• inspector/front-end/NetworkPanel.js (modified) (5 diffs)
• inspector/front-end/networkPanel.css (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-24  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Web Inspector: polish network panel UI.
+        https://bugs.webkit.org/show_bug.cgi?id=48205
+
+        * inspector/front-end/Images/frame.png:
+        * inspector/front-end/Images/networkIcon.png:
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel.prototype._createTable):
+        (WebInspector.NetworkPanel.prototype._setLargerResources):
+        (WebInspector.NetworkPanel.prototype._toggleGridMode):
+        * inspector/front-end/networkPanel.css:
+        (.network.panel .data-grid td):
+        (.network.panel .data-grid.small td):
+        (#network-views .resource-view.headers-visible .resource-view-content):
+        (#network-views.small .resource-view.headers-visible .resource-view-content):
+        (#network-views .resource-view-headers):
+        (#network-views.small .resource-view-headers):
+        (#network-views .resource-view .tabbed-pane-header):
+        (#network-views.small .resource-view .tabbed-pane-header):
+
 2010-10-24  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/WebCore/inspector/front-end/NetworkPanel.js

@@ -181 +181 @@
         columns.type.title = WebInspector.UIString("Type");
         columns.type.sortable = true;
-        columns.type.width = "7%";
+        columns.type.width = "10%";
 
         columns.size.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Size"), WebInspector.UIString("Transfer"));
@@ -195 +195 @@
         columns.timeline.title = "";
         columns.timeline.sortable = false;
-        columns.timeline.width = "40%";
+        columns.timeline.width = "37%";
         columns.timeline.sort = "ascending";
 
@@ -252 +252 @@
 
         var header = this._dataGrid.headerTableHeader("timeline");
-        header.firstChild.appendChild(timelineSorting);
+        header.replaceChild(timelineSorting, header.firstChild);
 
         timelineSorting.addEventListener("click", function(event) { event.stopPropagation() }, false);
@@ -872 +872 @@
             this._dataGrid.element.addStyleClass("small");
             this._timelineGrid.element.addStyleClass("small");
+            this._viewsContainerElement.addStyleClass("small");
         } else {
             this._largerResourcesButton.title = WebInspector.UIString("Use small resource rows.");
             this._dataGrid.element.removeStyleClass("small");
             this._timelineGrid.element.removeStyleClass("small");
+            this._viewsContainerElement.removeStyleClass("small");
         }
     },
@@ -1014 +1016 @@
             widths.method = 7;
             widths.status = 8;
-            widths.type = 7;
+            widths.type = 10;
             widths.size = 10;
             widths.time = 10;
-            widths.timeline = 40;
+            widths.timeline = 37;
         }
 

trunk/WebCore/inspector/front-end/networkPanel.css

@@ -25 +25 @@
 .network.panel .data-grid td {
     line-height: 17px;
+    height: 37px;
     border-right: 1px solid rgb(210, 210, 210);
     -webkit-user-select: none;
     vertical-align: middle;
+}
+
+.network.panel .data-grid.small td {
+    height: 17px;
 }
 
@@ -583 +588 @@
 }
 
-.network.panel .resource-view.headers-visible .resource-view-content {
+#network-views .resource-view.headers-visible .resource-view-content {
+    top: 31px;
+}
+
+#network-views.small .resource-view.headers-visible .resource-view-content {
+    top: 23px;
+}
+
+#network-views .resource-view-headers {
+    top: 31px;
+}
+
+#network-views.small .resource-view-headers {
     top: 23px;
 }
@@ -592 +609 @@
 }
 
-.network.panel .resource-view .tabbed-pane-header {
+#network-views .resource-view .tabbed-pane-header {
+    height: 31px;
+    padding-top: 11px;
+}
+
+#network-views.small .resource-view .tabbed-pane-header {
     height: 23px;
     padding-top: 3px;