Changeset 70437 in webkit

Timestamp:

Oct 24, 2010 10:29:53 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-10-24 Adam Barth <​abarth@webkit.org>

Reviewed by David Kilzer.

webkit-patch upload fails when the patch removes a file
​https://bugs.webkit.org/show_bug.cgi?id=48187

We need to use "--" to separate file names from the rest of the
command.

• Scripts/webkitpy/common/checkout/scm.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/checkout/scm.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-10-24  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by David Kilzer.
+
+        webkit-patch upload fails when the patch removes a file
+        https://bugs.webkit.org/show_bug.cgi?id=48187
+
+        We need to use "--" to separate file names from the rest of the
+        command.
+
+        * Scripts/webkitpy/common/checkout/scm.py:
+
 2010-10-24  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebKitTools/Scripts/webkitpy/common/checkout/scm.py

@@ -668 +668 @@
 
     def revisions_changing_file(self, path, limit=5):
-        commit_ids = self.run(["git", "log", "--pretty=format:%H", "-%s" % limit, path]).splitlines()
+        commit_ids = self.run(["git", "log", "--pretty=format:%H", "-%s" % limit, "--", path]).splitlines()
         return filter(lambda revision: revision, map(self.svn_revision_from_git_commit, commit_ids))