Changeset 70607 in webkit

Timestamp:

Oct 26, 2010 9:29:08 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-10-26 Eric Seidel <​eric@webkit.org>

Reviewed by David Kilzer.

build-webkit should collect Visual Studio Express logs and display them
​https://bugs.webkit.org/show_bug.cgi?id=39199

• Scripts/build-webkit:
• Scripts/print-vse-failure-logs: Added.
• Scripts/webkitdirs.pm:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/build-webkit (modified) (1 diff)
• Scripts/print-vse-failure-logs (added)
• Scripts/webkitdirs.pm (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-10-26  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by David Kilzer.
+
+        build-webkit should collect Visual Studio Express logs and display them
+        https://bugs.webkit.org/show_bug.cgi?id=39199
+
+        * Scripts/build-webkit:
+        * Scripts/print-vse-failure-logs: Added.
+        * Scripts/webkitdirs.pm:
+
 2010-10-26  David Kilzer  <ddkilzer@apple.com>
 

trunk/WebKitTools/Scripts/build-webkit

@@ -526 +526 @@
 
     if (exitStatus($result)) {
+        my $scriptDir = relativeScriptsDir();
+        if (usingVisualStudioExpress()) {
+            # Visual Studio Express is so lame it can't stdout build failures.
+            # So we find its logs and dump them to the console ourselves.
+            system(File::Spec->catfile($scriptDir, "print-vse-failure-logs"));
+        }
         if (isAppleWinWebKit()) {
             print "\n\n===== BUILD FAILED ======\n\n";
-            my $scriptDir = relativeScriptsDir();
             print "Please ensure you have run $scriptDir/update-webkit to install dependencies.\n\n";
             my $baseProductDir = baseProductDir();

trunk/WebKitTools/Scripts/webkitdirs.pm

@@ -1187 +1187 @@
 }
 
+sub usingVisualStudioExpress()
+{
+    determineConfigurationForVisualStudio();
+    return $willUseVCExpressWhenBuilding;
+}
+
 sub buildVisualStudioProject
 {