Changeset 70642 in webkit

Timestamp:

Oct 27, 2010 6:48:11 AM (13 years ago)

Author:

loki@webkit.org

Message:

2010-10-27 Gabor Loki <​loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Add cmn to branch32(reg, imm) on ARM
​https://bugs.webkit.org/show_bug.cgi?id=48062

The conditional comparison can be done with cmn if the imm value is
negative and can fit into the cmn instruction.

• assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::branch32):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MacroAssemblerARM.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-10-27  Gabor Loki  <loki@webkit.org>
+
+        Reviewed by Csaba Osztrogonác.
+
+        Add cmn to branch32(reg, imm) on ARM
+        https://bugs.webkit.org/show_bug.cgi?id=48062
+
+        The conditional comparison can be done with cmn if the imm value is
+        negative and can fit into the cmn instruction.
+
+        * assembler/MacroAssemblerARM.h:
+        (JSC::MacroAssemblerARM::branch32):
+
 2010-10-26  Oliver Hunt  <oliver@apple.com>
 

trunk/JavaScriptCore/assembler/MacroAssemblerARM.h

@@ -401 +401 @@
             m_assembler.ldr_un_imm(ARMRegisters::S0, right.m_value);
             m_assembler.cmp_r(left, ARMRegisters::S0);
-        } else
-            m_assembler.cmp_r(left, m_assembler.getImm(right.m_value, ARMRegisters::S0));
+        } else {
+            ARMWord tmp = m_assembler.getOp2(-right.m_value);
+            if (tmp != ARMAssembler::INVALID_IMM)
+                m_assembler.cmn_r(left, tmp);
+            else
+                m_assembler.cmp_r(left, m_assembler.getImm(right.m_value, ARMRegisters::S0));
+        }
         return Jump(m_assembler.jmp(ARMCondition(cond), useConstantPool));
     }