Changeset 70669 in webkit
- Timestamp:
- Oct 27, 2010 10:46:18 AM (14 years ago)
- Location:
- trunk
- Files:
-
- 2 deleted
- 30 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r70667 r70669 1 2010-10-27 Satish Sampath <satish@chromium.org> 2 3 Unreviewed, rolling out r70665. 4 http://trac.webkit.org/changeset/70665 5 https://bugs.webkit.org/show_bug.cgi?id=47089 6 7 Need to address Alexey's review comments. 8 9 * fast/speech/input-text-language-tag-expected.txt: Removed. 10 * fast/speech/input-text-language-tag.html: Removed. 11 * fast/speech/input-text-speechbutton.html: 12 * fast/speech/speech-button-ignore-generated-events.html: 13 * platform/chromium/test_expectations.txt: 14 1 15 2010-10-27 Dimitri Glazkov <dglazkov@chromium.org> 2 16 -
trunk/LayoutTests/fast/speech/input-text-speechbutton.html
r70665 r70669 33 33 function run() { 34 34 if (window.layoutTestController && window.eventSender) { 35 layoutTestController.setMockSpeechInputResult('Pictures of the moon' , '');35 layoutTestController.setMockSpeechInputResult('Pictures of the moon'); 36 36 37 37 // Clicking the speech button should fill in mock speech-recognized text. -
trunk/LayoutTests/fast/speech/speech-button-ignore-generated-events.html
r70665 r70669 50 50 if (window.layoutTestController && window.eventSender) { 51 51 // Running in DRT, test the eventSender case. 52 layoutTestController.setMockSpeechInputResult('Pictures of the moon' , '');52 layoutTestController.setMockSpeechInputResult('Pictures of the moon'); 53 53 document.getElementById('speechInput').onwebkitspeechchange = function() { 54 54 shouldBeEqualToString('document.getElementById("speechInput").value', 'Pictures of the moon'); -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r70665 r70669 3254 3254 // Chromium-mac-specific test, and only runs in DRT. 3255 3255 BUGWK46868 : platform/chromium/fast/text/chromium-mac-duplicate-ime-composition.html = TEXT 3256 3257 // Temporarily disabled for a 4-sided patch. Will be enabled again by BUGWK47420.3258 BUGWK47089 : fast/speech/input-text-language-tag.html = FAIL -
trunk/WebCore/ChangeLog
r70666 r70669 1 2010-10-27 Satish Sampath <satish@chromium.org> 2 3 Unreviewed, rolling out r70665. 4 http://trac.webkit.org/changeset/70665 5 https://bugs.webkit.org/show_bug.cgi?id=47089 6 7 Need to address Alexey's review comments. 8 9 * page/SpeechInput.cpp: 10 (WebCore::SpeechInput::startRecognition): 11 * page/SpeechInput.h: 12 * page/SpeechInputClient.h: 13 * platform/mock/SpeechInputClientMock.cpp: 14 (WebCore::SpeechInputClientMock::startRecognition): 15 (WebCore::SpeechInputClientMock::setRecognitionResult): 16 (WebCore::SpeechInputClientMock::timerFired): 17 * platform/mock/SpeechInputClientMock.h: 18 * rendering/TextControlInnerElements.cpp: 19 (WebCore::TextControlInnerElement::attachInnerElement): 20 (WebCore::SearchFieldCancelButtonElement::detach): 21 (WebCore::SpinButtonElement::defaultEventHandler): 22 (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): 23 (WebCore::InputFieldSpeechButtonElement::detach): 24 1 25 2010-10-27 ZHenyao Mo <zmo@google.com> 2 26 -
trunk/WebCore/page/SpeechInput.cpp
r70665 r70669 94 94 } 95 95 96 bool SpeechInput::startRecognition(int listenerId, const String& language, constIntRect& elementRect, const String& grammar)96 bool SpeechInput::startRecognition(int listenerId, const IntRect& elementRect, const String& grammar) 97 97 { 98 98 ASSERT(m_listeners.contains(listenerId)); 99 return m_client->startRecognition(listenerId, language,elementRect, grammar);99 return m_client->startRecognition(listenerId, elementRect, grammar); 100 100 } 101 101 -
trunk/WebCore/page/SpeechInput.h
r70665 r70669 62 62 63 63 // Methods invoked by the input elements. 64 bool startRecognition(int listenerId, const String& language, constIntRect& elementRect, const String& grammar);64 bool startRecognition(int listenerId, const IntRect& elementRect, const String& grammar); 65 65 void stopRecording(int); 66 66 void cancelRecognition(int); -
trunk/WebCore/page/SpeechInputClient.h
r70665 r70669 51 51 52 52 // Starts speech recognition and audio recording. 53 virtual bool startRecognition(int requestId, const String& language, constIntRect& elementRect, const String& grammar) = 0;53 virtual bool startRecognition(int requestId, const IntRect& elementRect, const String& grammar) = 0; 54 54 55 55 // Stops audio recording and performs recognition with the audio recorded until now -
trunk/WebCore/platform/mock/SpeechInputClientMock.cpp
r70665 r70669 36 36 #include "SpeechInputListener.h" 37 37 38 namespace {39 // HashMap doesn't support empty strings as keys, so this value (an invalid BCP47 tag) is used for those cases.40 const String emptyLanguage = "_";41 }42 43 38 namespace WebCore { 44 39 … … 56 51 } 57 52 58 bool SpeechInputClientMock::startRecognition(int requestId, const String& language, constIntRect& elementRect, const String& grammar)53 bool SpeechInputClientMock::startRecognition(int requestId, const IntRect& elementRect, const String& grammar) 59 54 { 60 55 if (m_timer.isActive()) … … 62 57 m_requestId = requestId; 63 58 m_recording = true; 64 m_language = language;65 59 m_timer.startOneShot(0); 66 60 return true; … … 87 81 } 88 82 89 void SpeechInputClientMock::setRecognitionResult(const String& result , const String& language)83 void SpeechInputClientMock::setRecognitionResult(const String& result) 90 84 { 91 if (language.isEmpty()) 92 m_recognitionResult.set(emptyLanguage, result); 93 else 94 m_recognitionResult.set(language, result); 85 m_recognitionResult = result; 95 86 } 96 87 … … 103 94 } else { 104 95 SpeechInputResultArray results; 105 106 // Empty language strings crash the HashMap. Using an invalid language value for that case. 107 String language = m_language.isEmpty() ? String(emptyLanguage) : m_language; 108 if (!m_recognitionResult.contains(language)) { 109 // Can't avoid setting a result on empty or invalid language strings. 110 // This would avoid generating the events used to check the results and the test would timeout. 111 String error("error: no result found for language '"); 112 error.append(m_language); 113 error.append("'"); 114 results.append(SpeechInputResult::create(error, 1.0)); 115 } else 116 results.append(SpeechInputResult::create(m_recognitionResult.get(language), 1.0)); 117 96 results.append(SpeechInputResult::create(m_recognitionResult, 1.0)); 118 97 m_listener->setRecognitionResult(m_requestId, results); 119 98 m_listener->didCompleteRecognition(m_requestId); -
trunk/WebCore/platform/mock/SpeechInputClientMock.h
r70665 r70669 35 35 #include "SpeechInputClient.h" 36 36 #include "Timer.h" 37 #include <wtf/HashMap.h>38 #include <wtf/text/StringHash.h>39 37 40 38 #if ENABLE(INPUT_SPEECH) … … 49 47 SpeechInputClientMock(); 50 48 51 void setRecognitionResult(const String& result , const String& language);49 void setRecognitionResult(const String& result); 52 50 53 51 // SpeechInputClient methods. 54 52 void setListener(SpeechInputListener*); 55 bool startRecognition(int requestId, const String& language, constIntRect& elementRect, const String& grammar);53 bool startRecognition(int requestId, const IntRect& elementRect, const String& grammar); 56 54 void stopRecording(int); 57 55 void cancelRecognition(int); … … 64 62 SpeechInputListener* m_listener; 65 63 int m_requestId; 66 67 HashMap<String, String> m_recognitionResult; 68 String m_language; 64 String m_recognitionResult; 69 65 }; 70 66 -
trunk/WebCore/rendering/TextControlInnerElements.cpp
r70665 r70669 22 22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 23 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 25 25 */ 26 26 27 27 #include "config.h" 28 28 #include "TextControlInnerElements.h" … … 108 108 renderer->setStyle(style); 109 109 } 110 110 111 111 // Set these explicitly since this normally happens during an attach() 112 112 setAttached(); 113 113 setInDocument(); 114 114 115 115 // For elements without a shadow parent, add the node to the DOM normally. 116 116 if (!m_shadowParent) { … … 119 119 parent->deprecatedParserAddChild(this); 120 120 } 121 121 122 122 // Add the renderer to the render tree 123 123 if (renderer) … … 209 209 if (m_capturing) { 210 210 if (Frame* frame = document()->frame()) 211 frame->eventHandler()->setCapturingMouseEventsNode(0); 211 frame->eventHandler()->setCapturingMouseEventsNode(0); 212 212 } 213 213 TextControlInnerElement::detach(); … … 282 282 if (!event->defaultHandled()) 283 283 HTMLDivElement::defaultEventHandler(event); 284 return; 285 } 286 284 return; 285 } 286 287 287 HTMLInputElement* input = static_cast<HTMLInputElement*>(shadowAncestorNode()); 288 288 if (input->disabled() || input->isReadOnlyFormControl()) { … … 432 432 switch (m_state) { 433 433 case Idle: 434 if (speechInput()->startRecognition(m_listenerId, input-> computeInheritedLanguage(), input->renderer()->absoluteBoundingBoxRect(), input->getAttribute(webkitgrammarAttr)))434 if (speechInput()->startRecognition(m_listenerId, input->renderer()->absoluteBoundingBoxRect(), input->getAttribute(webkitgrammarAttr))) 435 435 setState(Recording); 436 436 break; … … 490 490 if (m_capturing) { 491 491 if (Frame* frame = document()->frame()) 492 frame->eventHandler()->setCapturingMouseEventsNode(0); 492 frame->eventHandler()->setCapturingMouseEventsNode(0); 493 493 } 494 494 -
trunk/WebKit/chromium/ChangeLog
r70666 r70669 1 2010-10-27 Satish Sampath <satish@chromium.org> 2 3 Unreviewed, rolling out r70665. 4 http://trac.webkit.org/changeset/70665 5 https://bugs.webkit.org/show_bug.cgi?id=47089 6 7 Need to address Alexey's review comments. 8 9 * public/WebSpeechInputController.h: 10 (WebKit::WebSpeechInputController::startRecognition): 11 * public/WebSpeechInputControllerMock.h: 12 * src/SpeechInputClientImpl.cpp: 13 (WebKit::SpeechInputClientImpl::startRecognition): 14 * src/SpeechInputClientImpl.h: 15 * src/WebSpeechInputControllerMockImpl.cpp: 16 (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): 17 (WebKit::WebSpeechInputControllerMockImpl::startRecognition): 18 * src/WebSpeechInputControllerMockImpl.h: 19 * src/WebViewImpl.cpp: 20 (WebKit::WebViewImpl::WebViewImpl): 21 * src/WebViewImpl.h: 22 1 23 2010-10-27 ZHenyao Mo <zmo@google.com> 2 24 -
trunk/WebKit/chromium/public/WebSpeechInputController.h
r70665 r70669 36 36 namespace WebKit { 37 37 38 class WebString;39 38 struct WebRect; 40 39 class WebString; … … 46 45 // runs to the limit or stopRecording is called. Progress indications and the recognized 47 46 // text are returned via the listener interface. 48 virtual bool startRecognition(int requestId, const Web String& language, const WebRect& elementRect, const WebString& grammar)47 virtual bool startRecognition(int requestId, const WebRect& elementRect, const WebString& grammar) 49 48 { 50 startRecognition(requestId, language,elementRect);49 startRecognition(requestId, elementRect); 51 50 return false; 52 51 } 53 52 54 53 // FIXME: Remove this method once chromium implements the above method. 55 virtual bool startRecognition(int requestId, const Web String& language, const WebRect& elementRect)54 virtual bool startRecognition(int requestId, const WebRect&) 56 55 { 57 56 WEBKIT_ASSERT_NOT_REACHED(); -
trunk/WebKit/chromium/public/WebSpeechInputControllerMock.h
r70665 r70669 45 45 virtual ~WebSpeechInputControllerMock() { } 46 46 47 virtual void setMockRecognitionResult(const WebString& result, const WebString& language) = 0;48 49 // FIXME: this is a fix for a two-sided patch. Delete as soon as the chromium side is patched.50 // Chromium patch not uploaded yet, but will depend on http://codereview.chromium.org/3615005/show patch.51 47 virtual void setMockRecognitionResult(const WebString& result) = 0; 52 48 }; -
trunk/WebKit/chromium/src/SpeechInputClientImpl.cpp
r70665 r70669 33 33 34 34 #include "PlatformString.h" 35 #include "SpeechInputListener.h"36 35 #include "WebSpeechInputController.h" 37 36 #include "WebString.h" 38 37 #include "WebViewClient.h" 39 #include <wtf/PassOwnPtr.h>38 #include "page/SpeechInputListener.h" 40 39 41 40 #if ENABLE(INPUT_SPEECH) 42 41 43 42 namespace WebKit { 44 45 PassOwnPtr<SpeechInputClientImpl> SpeechInputClientImpl::create(WebViewClient* client)46 {47 return adoptPtr(new SpeechInputClientImpl(client));48 }49 43 50 44 SpeechInputClientImpl::SpeechInputClientImpl(WebViewClient* web_view_client) … … 63 57 } 64 58 65 bool SpeechInputClientImpl::startRecognition(int requestId, const String& language, const WebCore::IntRect& elementRect, constString& grammar)59 bool SpeechInputClientImpl::startRecognition(int requestId, const WebCore::IntRect& elementRect, const WTF::String& grammar) 66 60 { 67 61 ASSERT(m_listener); 68 return m_controller->startRecognition(requestId, language,elementRect, grammar);62 return m_controller->startRecognition(requestId, elementRect, grammar); 69 63 } 70 64 -
trunk/WebKit/chromium/src/SpeechInputClientImpl.h
r70665 r70669 34 34 #if ENABLE(INPUT_SPEECH) 35 35 36 #include "SpeechInputClient.h"37 36 #include "WebSpeechInputListener.h" 38 #include <wtf/Forward.h> 39 #include <wtf/OwnPtr.h> 40 #include <wtf/PassOwnPtr.h> 37 #include "page/SpeechInputClient.h" 41 38 42 39 namespace WebCore { … … 53 50 public WebSpeechInputListener { 54 51 public: 55 static PassOwnPtr<SpeechInputClientImpl> create(WebViewClient*);52 SpeechInputClientImpl(WebViewClient*); 56 53 virtual ~SpeechInputClientImpl(); 57 54 58 55 // SpeechInputClient methods. 59 56 void setListener(WebCore::SpeechInputListener*); 60 bool startRecognition(int requestId, const String& language, const WebCore::IntRect& elementRect, constString& grammar);57 bool startRecognition(int requestId, const WebCore::IntRect& elementRect, const WTF::String& grammar); 61 58 void stopRecording(int); 62 59 void cancelRecognition(int); … … 68 65 69 66 private: 70 SpeechInputClientImpl(WebViewClient*);71 72 67 WebSpeechInputController* m_controller; // To call into the embedder. 73 68 WebCore::SpeechInputListener* m_listener; -
trunk/WebKit/chromium/src/WebSpeechInputControllerMockImpl.cpp
r70665 r70669 58 58 void WebSpeechInputControllerMockImpl::setMockRecognitionResult(const WebString& result) 59 59 { 60 m_webcoreMock->setRecognitionResult(result, WebString::fromUTF8("")); 61 } 62 63 void WebSpeechInputControllerMockImpl::setMockRecognitionResult(const WebString& result, const WebString &language) 64 { 65 m_webcoreMock->setRecognitionResult(result, language); 60 m_webcoreMock->setRecognitionResult(result); 66 61 } 67 62 … … 81 76 } 82 77 83 bool WebSpeechInputControllerMockImpl::startRecognition(int requestId, const Web String& language, const WebRect& elementRect, const WebString& grammar)78 bool WebSpeechInputControllerMockImpl::startRecognition(int requestId, const WebRect& elementRect, const WebString& grammar) 84 79 { 85 return m_webcoreMock->startRecognition(requestId, language,elementRect, grammar);80 return m_webcoreMock->startRecognition(requestId, elementRect, grammar); 86 81 } 87 82 -
trunk/WebKit/chromium/src/WebSpeechInputControllerMockImpl.h
r70665 r70669 58 58 59 59 // WebSpeechInputController methods. 60 bool startRecognition(int requestId, const Web String& language, const WebRect& elementRect, const WebString& grammar);60 bool startRecognition(int requestId, const WebRect& elementRect, const WebString& grammar); 61 61 void cancelRecognition(int requestId); 62 62 void stopRecording(int requestId); 63 63 64 64 // WebSpeechInputControllerMock methods. 65 void setMockRecognitionResult(const WebString& result, const WebString& language);66 67 // FIXME: this is a fix for a two-sided patch. Delete as soon as the chromium side is patched.68 // Chromium patch not uploaded yet, but will depend on http://codereview.chromium.org/3615005/show patch.69 65 void setMockRecognitionResult(const WebString& result); 70 66 … … 77 73 78 74 #endif // WebSpeechInputControllerMockImpl_h 75 -
trunk/WebKit/chromium/src/WebViewImpl.cpp
r70665 r70669 89 89 #include "SelectionController.h" 90 90 #include "Settings.h" 91 #include "SpeechInputClientImpl.h"92 91 #include "Timer.h" 93 92 #include "TypingCommand.h" … … 284 283 #endif 285 284 #if ENABLE(INPUT_SPEECH) 286 , m_speechInputClient( SpeechInputClientImpl::create(client))285 , m_speechInputClient(client) 287 286 #endif 288 287 , m_deviceOrientationClientProxy(new DeviceOrientationClientProxy(client ? client->deviceOrientationClient() : 0)) … … 307 306 pageClients.inspectorClient = &m_inspectorClientImpl; 308 307 #if ENABLE(INPUT_SPEECH) 309 pageClients.speechInputClient = m_speechInputClient.get();308 pageClients.speechInputClient = &m_speechInputClient; 310 309 #endif 311 310 pageClients.deviceOrientationClient = m_deviceOrientationClientProxy.get(); -
trunk/WebKit/chromium/src/WebViewImpl.h
r70665 r70669 50 50 #include "LayerRendererChromium.h" 51 51 #include "NotificationPresenterImpl.h" 52 #include "SpeechInputClientImpl.h" 52 53 #include <wtf/OwnPtr.h> 53 54 #include <wtf/RefCounted.h> … … 74 75 class DeviceOrientationClientProxy; 75 76 class DragScrollTimer; 76 class SpeechInputClientImpl;77 77 class WebAccessibilityObject; 78 78 class WebDevToolsAgentClient; … … 549 549 550 550 #if ENABLE(INPUT_SPEECH) 551 OwnPtr<SpeechInputClientImpl>m_speechInputClient;551 SpeechInputClientImpl m_speechInputClient; 552 552 #endif 553 553 // If we attempt to fetch the on-screen GraphicsContext3D before -
trunk/WebKitTools/ChangeLog
r70665 r70669 1 2010-10-27 Satish Sampath <satish@chromium.org> 2 3 Unreviewed, rolling out r70665. 4 http://trac.webkit.org/changeset/70665 5 https://bugs.webkit.org/show_bug.cgi?id=47089 6 7 Need to address Alexey's review comments. 8 9 * DumpRenderTree/LayoutTestController.cpp: 10 (setMockSpeechInputResultCallback): 11 * DumpRenderTree/LayoutTestController.h: 12 * DumpRenderTree/chromium/LayoutTestController.cpp: 13 (LayoutTestController::setMockSpeechInputResult): 14 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15 (LayoutTestController::setMockSpeechInputResult): 16 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 17 (LayoutTestController::setMockSpeechInputResult): 18 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 19 (LayoutTestController::setMockSpeechInputResult): 20 * DumpRenderTree/qt/LayoutTestControllerQt.h: 21 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 22 (LayoutTestController::setMockSpeechInputResult): 23 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 24 (LayoutTestController::setMockSpeechInputResult): 25 1 26 2010-10-27 Leandro Gracia Gil <leandrogracia@google.com> 2 27 -
trunk/WebKitTools/DumpRenderTree/LayoutTestController.cpp
r70665 r70669 1079 1079 static JSValueRef setMockSpeechInputResultCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception) 1080 1080 { 1081 if (argumentCount < 2)1081 if (argumentCount < 1) 1082 1082 return JSValueMakeUndefined(context); 1083 1083 … … 1085 1085 ASSERT(!*exception); 1086 1086 1087 JSRetainPtr<JSStringRef> language(Adopt, JSValueToStringCopy(context, arguments[1], exception)); 1088 ASSERT(!*exception); 1089 1090 LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject)); 1091 controller->setMockSpeechInputResult(result.get(), language.get()); 1087 LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject)); 1088 controller->setMockSpeechInputResult(result.get()); 1092 1089 1093 1090 return JSValueMakeUndefined(context); -
trunk/WebKitTools/DumpRenderTree/LayoutTestController.h
r70665 r70669 95 95 void setMockGeolocationError(int code, JSStringRef message); 96 96 void setMockGeolocationPosition(double latitude, double longitude, double accuracy); 97 void setMockSpeechInputResult(JSStringRef result , JSStringRef language);97 void setMockSpeechInputResult(JSStringRef result); 98 98 void setPersistentUserStyleSheetLocation(JSStringRef path); 99 99 void setPluginsEnabled(bool flag); -
trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp
r70665 r70669 1535 1535 { 1536 1536 result->setNull(); 1537 if (arguments.size() < 2 || !arguments[0].isString() || !arguments[1].isString())1538 return; 1539 1540 m_speechInputControllerMock->setMockRecognitionResult(cppVariantToWebString(arguments[0]) , cppVariantToWebString(arguments[1]));1537 if (arguments.size() < 1 || !arguments[0].isString()) 1538 return; 1539 1540 m_speechInputControllerMock->setMockRecognitionResult(cppVariantToWebString(arguments[0])); 1541 1541 } 1542 1542 -
trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
r70665 r70669 502 502 } 503 503 504 void LayoutTestController::setMockSpeechInputResult(JSStringRef result , JSStringRef language)504 void LayoutTestController::setMockSpeechInputResult(JSStringRef result) 505 505 { 506 506 // FIXME: Implement for speech input layout tests. -
trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
r70665 r70669 372 372 } 373 373 374 void LayoutTestController::setMockSpeechInputResult(JSStringRef result , JSStringRef language)374 void LayoutTestController::setMockSpeechInputResult(JSStringRef result) 375 375 { 376 376 // FIXME: Implement for speech input layout tests. -
trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
r70665 r70669 766 766 } 767 767 768 void LayoutTestController::setMockSpeechInputResult(const QString& result , const QString& language)768 void LayoutTestController::setMockSpeechInputResult(const QString& result) 769 769 { 770 770 // FIXME: Implement for speech input layout tests. -
trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h
r70665 r70669 217 217 bool geolocationPermission() const { return m_geolocationPermission; } 218 218 219 void setMockSpeechInputResult(const QString& result , const QString& language);219 void setMockSpeechInputResult(const QString& result); 220 220 221 221 // Empty stub method to keep parity with object model exposed by global LayoutTestController. -
trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
r70665 r70669 406 406 } 407 407 408 void LayoutTestController::setMockSpeechInputResult(JSStringRef result , JSStringRef language)408 void LayoutTestController::setMockSpeechInputResult(JSStringRef result) 409 409 { 410 410 // FIXME: Implement for speech input layout tests. -
trunk/WebKitTools/DumpRenderTree/wx/LayoutTestControllerWx.cpp
r70665 r70669 321 321 } 322 322 323 void LayoutTestController::setMockSpeechInputResult(JSStringRef result , JSStringRef language)323 void LayoutTestController::setMockSpeechInputResult(JSStringRef result) 324 324 { 325 325 // FIXME: Implement for speech input layout tests. … … 529 529 return 0; 530 530 } 531
Note: See TracChangeset
for help on using the changeset viewer.