Changeset 71068 in webkit

Timestamp:

Nov 1, 2010 4:01:05 PM (13 years ago)

Author:

dpranke@chromium.org

Message:

2010-11-01 Dirk Pranke <​dpranke@chromium.org>

Reviewed by James Robinson.

new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
​https://bugs.webkit.org/show_bug.cgi?id=48790

• Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
• Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/chromium_gpu.py (modified) (4 diffs)
• Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-11-01  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by James Robinson.
+
+        new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
+        https://bugs.webkit.org/show_bug.cgi?id=48790
+
+        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
+
 2010-11-01  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py

@@ -72 +72 @@
         if options.builder_name is not None:
             options.builder_name = options.builder_name + ' - GPU'
+        if options.use_drt is None:
+            options.use_drt = True
 
 
@@ -97 +99 @@
                 chromium_linux.ChromiumLinuxPort.baseline_search_path(self))
 
+    def default_child_processes(self):
+        return 1
+
     def path_to_test_expectations_file(self):
         return self.path_from_webkit_base('LayoutTests', 'platform',
@@ -114 +119 @@
         return (map(self._webkit_baseline_path, ['chromium-gpu-mac', 'chromium-gpu']) +
                 chromium_mac.ChromiumMacPort.baseline_search_path(self))
+
+    def default_child_processes(self):
+        return 1
 
     def path_to_test_expectations_file(self):
@@ -133 +141 @@
                 chromium_win.ChromiumWinPort.baseline_search_path(self))
 
+    def default_child_processes(self):
+        return 1
+
     def path_to_test_expectations_file(self):
         return self.path_from_webkit_base('LayoutTests', 'platform',

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py

@@ -46 +46 @@
         mock_options = mocktool.MockOptions(accelerated_compositing=None,
                                             accelerated_2d_canvas=None,
-                                            builder_name='foo')
+                                            builder_name='foo',
+                                            use_drt=None,
+                                            child_processes=None)
         port = chromium_gpu.get(port_name=port_name, options=mock_options)
         self.assertTrue(port._options.accelerated_compositing)
         self.assertTrue(port._options.accelerated_2d_canvas)
+        self.assertTrue(port._options.use_drt)
+        self.assertEqual(port.default_child_processes(), 1)
         self.assertEqual(port._options.builder_name, 'foo - GPU')