Changeset 71099 in webkit

Timestamp:

Nov 1, 2010, 9:34:34 PM (15 years ago)

Author:

Martin Robinson

Message:

2010-11-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] PopupMenuGtk has a very confusing if-else block
​https://bugs.webkit.org/show_bug.cgi?id=48816

Small code cleanup for PopupMenuGtk.

• platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/PopupMenuGtk.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-01  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Daniel Bates.
+
+        [GTK] PopupMenuGtk has a very confusing if-else block
+        https://bugs.webkit.org/show_bug.cgi?id=48816
+
+        Small code cleanup for PopupMenuGtk.
+
+        * platform/gtk/PopupMenuGtk.cpp:
+        (WebCore::PopupMenuGtk::show):
+
 2010-11-01  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/platform/gtk/PopupMenuGtk.cpp

@@ -98 +98 @@
     GList* children = gtk_container_get_children(GTK_CONTAINER(m_popup.get()));
     GList* p = children;
-    if (size)
+    if (size) {
         for (int i = 0; i < size; i++) {
             if (i > index)
@@ -113 +113 @@
 
             p = g_list_next(p);
-        } else
-            // Center vertically the empty popup in the combo box area
-            m_menuPosition.setY(m_menuPosition.y() - rect.height() / 2);
+        }
+    } else {
+        // Center vertically the empty popup in the combo box area
+        m_menuPosition.setY(m_menuPosition.y() - rect.height() / 2);
+    }
 
     g_list_free(children);