Changeset 71116 in webkit

Timestamp:

Nov 2, 2010 8:36:52 AM (14 years ago)

Author:

Adam Roben

Message:

Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on

This reverts Windows to our pre-r71097 behavior. That patch made us
track all resource identifiers, including the main resource, so the
main resource's URL started appearing in test output instead of
"<unknown>". Arguably having the main resource's URL is better, but all
other platforms print "<unknown>" and we want to match.

Fixes <​http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
(r71097): Many http tests failing on Windows

Reviewed by Anders Carlsson.

• DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::identifierForInitialRequest): Don't add the
identifier to the URL map if we're not supposed to dump resource load
callbacks.
(ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
identifier from the URL map even if we're already "done". There's no
point in keeping out-of-date identifiers around.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/win/ResourceLoadDelegate.cpp (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-11-02  Adam Roben  <aroben@apple.com>
+
+        Only track resource identifiers in DRT when dumpResourceLoadCallbacks
+        is on
+
+        This reverts Windows to our pre-r71097 behavior. That patch made us
+        track all resource identifiers, including the main resource, so the
+        main resource's URL started appearing in test output instead of
+        "<unknown>". Arguably having the main resource's URL is better, but all
+        other platforms print "<unknown>" and we want to match.
+
+        Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
+        (r71097): Many http tests failing on Windows
+
+        Reviewed by Anders Carlsson.
+
+        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
+        (ResourceLoadDelegate::identifierForInitialRequest): Don't add the
+        identifier to the URL map if we're not supposed to dump resource load
+        callbacks.
+        (ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
+        identifier from the URL map even if we're already "done". There's no
+        point in keeping out-of-date identifiers around.
+
 2010-11-01  Jenn Braithwaite  <jennb@chromium.org>
 

trunk/WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.cpp

@@ -217 +217 @@
     /* [in] */ unsigned long identifier)
 { 
-    if (!done) {
+    if (!done && gLayoutTestController->dumpResourceLoadCallbacks()) {
         BSTR urlStr;
         if (FAILED(request->URL(&urlStr)))
@@ -233 +233 @@
     /* [in] */ unsigned long identifier)
 {
-    if (!done) {
-        ASSERT(urlMap().contains(identifier));
-        urlMap().remove(identifier);
-    }
+    urlMap().remove(identifier);
 
     return S_OK;