Changeset 71120 in webkit

Timestamp:

Nov 2, 2010 9:04:29 AM (14 years ago)

Author:

dbates@webkit.org

Message:

2010-11-02 Daniel Bates <​dbates@rim.com>

Reviewed by Martin Robinson.

Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
​https://bugs.webkit.org/show_bug.cgi?id=48806

Make the frame creation process in the GTK-port consistent with the
Mac, Qt, and Haiku ports. In particular, set the name of the new
frame before it's appended to the frame tree.

At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <​http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.

• WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):

2010-11-02 Daniel Bates <​dbates@rim.com>

Reviewed by Martin Robinson.

Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
​https://bugs.webkit.org/show_bug.cgi?id=48806

Make the frame creation process in the Apple Windows-port consistent
with the Mac, Qt, and Haiku ports. In particular, set the name of
the new frame before it's appended to the frame tree.

At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <​http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.

• WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame):

2010-11-02 Daniel Bates <​dbates@rim.com>

Reviewed by Martin Robinson.

Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
​https://bugs.webkit.org/show_bug.cgi?id=48806

Make the frame creation process in the EFL-port consistent with the
Mac, Qt, and Haiku ports. In particular, set the name of the new
frame before it's appended to the frame tree.

At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <​http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.

• ewk/ewk_frame.cpp: (ewk_frame_child_add):

Location:

trunk/WebKit

Files:

• efl/ChangeLog (modified) (1 diff)
• efl/ewk/ewk_frame.cpp (modified) (1 diff)
• gtk/ChangeLog (modified) (1 diff)
• gtk/WebCoreSupport/FrameLoaderClientGtk.cpp (modified) (1 diff)
• win/ChangeLog (modified) (1 diff)
• win/WebCoreSupport/WebFrameLoaderClient.cpp (modified) (1 diff)

trunk/WebKit/efl/ChangeLog

@@ +1 @@
+2010-11-02  Daniel Bates  <dbates@rim.com>
+
+        Reviewed by Martin Robinson.
+
+        Set frame name before appending it to the frame tree in the Apple Windows,
+        GTK, and EFL ports
+        https://bugs.webkit.org/show_bug.cgi?id=48806
+
+        Make the frame creation process in the EFL-port consistent with the
+        Mac, Qt, and Haiku ports. In particular, set the name of the new
+        frame before it's appended to the frame tree.
+
+        At this time we cannot test this change since it is being masked by
+        HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
+        We'll be able to test this once we fix bug #6751.
+
+        * ewk/ewk_frame.cpp:
+        (ewk_frame_child_add):
+
 2010-11-01  Brady Eidson  <beidson@apple.com>
 

trunk/WebKit/efl/ewk/ewk_frame.cpp

@@ -1624 +1624 @@
 
     cf = child.get();
-    sd->frame->tree()->appendChild(child);
     if (cf->tree())
         cf->tree()->setName(name);
     else
         ERR("no tree for child object");
+    sd->frame->tree()->appendChild(child);
 
     if (!ewk_frame_init(frame, sd->view, cf)) {

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2010-11-02  Daniel Bates  <dbates@rim.com>
+
+        Reviewed by Martin Robinson.
+
+        Set frame name before appending it to the frame tree in the Apple Windows,
+        GTK, and EFL ports
+        https://bugs.webkit.org/show_bug.cgi?id=48806
+
+        Make the frame creation process in the GTK-port consistent with the
+        Mac, Qt, and Haiku ports. In particular, set the name of the new
+        frame before it's appended to the frame tree.
+
+        At this time we cannot test this change since it is being masked by
+        HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
+        We'll be able to test this once we fix bug #6751.
+
+        * WebCoreSupport/FrameLoaderClientGtk.cpp:
+        (WebKit::FrameLoaderClient::createFrame):
+
 2010-11-01  Jennifer Braithwaite  <jennb@google.com>
 

trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

@@ -585 +585 @@
     framePrivate->coreFrame = childFrame.get();
 
+    childFrame->tree()->setName(name);
     parentFrame->tree()->appendChild(childFrame);
-    childFrame->tree()->setName(name);
     childFrame->init();
 

trunk/WebKit/win/ChangeLog

@@ +1 @@
+2010-11-02  Daniel Bates  <dbates@rim.com>
+
+        Reviewed by Martin Robinson.
+
+        Set frame name before appending it to the frame tree in the Apple Windows,
+        GTK, and EFL ports
+        https://bugs.webkit.org/show_bug.cgi?id=48806
+
+        Make the frame creation process in the Apple Windows-port consistent
+        with the Mac, Qt, and Haiku ports. In particular, set the name of
+        the new frame before it's appended to the frame tree.
+
+        At this time we cannot test this change since it is being masked by
+        HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
+        We'll be able to test this once we fix bug #6751.
+
+        * WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebFrameLoaderClient::createFrame):
+
 2010-11-01  Jenn Braithwaite  <jennb@chromium.org>
 

trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

@@ -775 +775 @@
     RefPtr<Frame> childFrame = webFrame->init(m_webFrame->webView(), coreFrame->page(), ownerElement);
 
+    childFrame->tree()->setName(name);
     coreFrame->tree()->appendChild(childFrame);
-    childFrame->tree()->setName(name);
     childFrame->init();