Changeset 71147 in webkit

Timestamp:

Nov 2, 2010 12:15:19 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2010-11-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
​https://bugs.webkit.org/show_bug.cgi?id=47166

We need to pop all the open elements when we end the document in the
AfterAfterBody state.

Test: fast/parser/pop-all-after-after-body.html

• html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):

2010-11-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
​https://bugs.webkit.org/show_bug.cgi?id=47166

Test that :last-child works when we end the document in the
AfterAfterBody state.

• fast/parser/pop-all-after-after-body-expected.txt: Added.
• fast/parser/pop-all-after-after-body.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/pop-all-after-after-body-expected.txt (added)
• LayoutTests/fast/parser/pop-all-after-after-body.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/parser/HTMLTreeBuilder.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-02  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
+        https://bugs.webkit.org/show_bug.cgi?id=47166
+
+        Test that :last-child works when we end the document in the
+        AfterAfterBody state.
+
+        * fast/parser/pop-all-after-after-body-expected.txt: Added.
+        * fast/parser/pop-all-after-after-body.html: Added.
+
 2010-11-02  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-02  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
+        https://bugs.webkit.org/show_bug.cgi?id=47166
+
+        We need to pop all the open elements when we end the document in the
+        AfterAfterBody state.
+
+        Test: fast/parser/pop-all-after-after-body.html
+
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::processEndOfFile):
+
 2010-11-02  Patrick Gansterer  <paroga@webkit.org>
 

trunk/WebCore/html/parser/HTMLTreeBuilder.cpp

@@ -2581 +2581 @@
     case AfterAfterBodyMode:
         ASSERT(insertionMode() == AfterBodyMode || insertionMode() == AfterAfterBodyMode);
-        return;
+        break;
     case InHeadNoscriptMode:
         ASSERT(insertionMode() == InHeadNoscriptMode);
@@ -2603 +2603 @@
         if (m_tree.currentElement() == m_tree.openElements()->htmlElement()) {
             ASSERT(isParsingFragment());
-            return;
+            return; // FIXME: Should we break here instead of returning?
         }
         if (!processColgroupEndTagForInColumnGroup()) {
             ASSERT(isParsingFragment());
-            return;
+            return; // FIXME: Should we break here instead of returning?
         }
         prepareToReprocessToken();