Changeset 71198 in webkit


Ignore:
Timestamp:
Nov 2, 2010 6:20:46 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-11-02 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Chromium: Propagate a document value changed notification on scroll.
​https://bugs.webkit.org/show_bug.cgi?id=48817

  • platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-ValueChanged.html:

2010-11-02 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Chromium: Propagate a document value changed notification on scroll.
​https://bugs.webkit.org/show_bug.cgi?id=48817

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isAccessibilityScrollbar):
  • accessibility/AccessibilityScrollbar.h: (WebCore::AccessibilityScrollbar::scrollbar): (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):

2010-11-02 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Chromium: Propagate a document value changed notification on scroll.
​https://bugs.webkit.org/show_bug.cgi?id=48817

  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::boundingBoxRect):
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r71197 r71198  
     12010-11-02  Chris Guillory  <chris.guillory@google.com>
     2
     3        Reviewed by Chris Fleizach.
     4
     5        Chromium: Propagate a document value changed notification on scroll.
     6        https://bugs.webkit.org/show_bug.cgi?id=48817
     7
     8        * platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
     9        * platform/chromium/accessibility/post-notification-ValueChanged.html:
     10
    1112010-11-02  Dmitry Titov  <dimich@chromium.org>
    212

  • trunk/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged-expected.txt

    r68240 r71198  
     1AccessibilityNotification - ValueChanged
    12AccessibilityNotification - ValueChanged - id:text-for-ValueChanged
    23AccessibilityNotification - LoadComplete

  • trunk/LayoutTests/platform/chromium/accessibility/post-notification-ValueChanged.html

    r67498 r71198  
    33<script>
    44    function testNotification() {
    5         document.getElementById("text-for-ValueChanged").value = "button"
     5        // Scroll the window which should generate an accessibility value changed
     6        // notification for top document's vertical scrollbar.
     7        if (window.eventSender)
     8            window.eventSender.keyDown("pageDown");
     9
     10        document.getElementById("text-for-ValueChanged").value = "button";
    611    }
    712</script>
    813</head>
    9 <body onload="test()">
     14<body onload="test()" style="height:200%;">
    1015This tests that chromium correctly recieves the ValueChanged notification.
    1116

  • trunk/WebCore/ChangeLog

    r71195 r71198  
     12010-11-02  Chris Guillory  <chris.guillory@google.com>
     2
     3        Reviewed by Chris Fleizach.
     4
     5        Chromium: Propagate a document value changed notification on scroll.
     6        https://bugs.webkit.org/show_bug.cgi?id=48817
     7
     8        * accessibility/AccessibilityObject.h:
     9        (WebCore::AccessibilityObject::isAccessibilityScrollbar):
     10        * accessibility/AccessibilityScrollbar.h:
     11        (WebCore::AccessibilityScrollbar::scrollbar):
     12        (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
     13        * accessibility/chromium/AXObjectCacheChromium.cpp:
     14        (WebCore::AXObjectCache::postPlatformNotification):
     15
    1162010-11-02  Chris Rogers  <crogers@google.com>
    217

  • trunk/WebCore/accessibility/AccessibilityObject.h

    r70554 r71198  
    260260   
    261261    virtual bool isAccessibilityRenderObject() const { return false; }
     262    virtual bool isAccessibilityScrollbar() const { return false; }
    262263    virtual bool isAnchor() const { return false; }
    263264    virtual bool isAttachment() const { return false; }

  • trunk/WebCore/accessibility/AccessibilityScrollbar.h

    r53644 r71198  
    4242    void setScrollbar(Scrollbar* scrollbar) { m_scrollbar = scrollbar; }
    4343
     44    Scrollbar* scrollbar() const { return m_scrollbar; }
     45
     46    virtual bool isAccessibilityScrollbar() const { return true; }
     47
    4448    virtual AccessibilityRole roleValue() const { return ScrollBarRole; }
    4549

  • trunk/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp

    r68240 r71198  
    2828#include "AXObjectCache.h"
    2929#include "AccessibilityObject.h"
     30#include "AccessibilityScrollbar.h"
    3031#include "Chrome.h"
    3132#include "ChromeClient.h"
    3233#include "FrameView.h"
     34#include "Scrollbar.h"
    3335
    3436namespace WebCore {
    … …  
    4850void AXObjectCache::postPlatformNotification(AccessibilityObject* obj, AXNotification notification)
    4951{
     52    if (obj->isAccessibilityScrollbar() && notification == AXValueChanged) {
     53        // Send document value changed on scrollbar value changed notification.
     54        Scrollbar* scrollBar = static_cast<AccessibilityScrollbar*>(obj)->scrollbar();
     55        if (!scrollBar || !scrollBar->parent() || !scrollBar->parent()->isFrameView())
     56            return;
     57        Document* document = static_cast<FrameView*>(scrollBar->parent())->frame()->document();
     58        if (document != document->topDocument())
     59            return;
     60        obj = get(document->renderer());
     61    }
     62   
    5063    if (!obj || !obj->document() || !obj->documentFrameView() || !obj->documentFrameView()->frame() || !obj->documentFrameView()->frame()->page())
    5164        return;

  • trunk/WebKit/chromium/ChangeLog

    r71186 r71198  
     12010-11-02  Chris Guillory  <chris.guillory@google.com>
     2
     3        Reviewed by Chris Fleizach.
     4
     5        Chromium: Propagate a document value changed notification on scroll.
     6        https://bugs.webkit.org/show_bug.cgi?id=48817
     7
     8        * src/WebAccessibilityObject.cpp:
     9        (WebKit::WebAccessibilityObject::boundingBoxRect):
     10
    1112010-10-29  John Abd-El-Malek  <jam@chromium.org>
    212

  • trunk/WebKit/chromium/src/WebAccessibilityObject.cpp

    r67418 r71198  
    352352
    353353    m_private->updateBackingStore();
    354     return m_private->documentFrameView()->contentsToWindow(m_private->boundingBoxRect());
     354    return m_private->boundingBoxRect();
    355355}
    356356
Note: See TracChangeset for help on using the changeset viewer.