Changeset 71510 in webkit


Ignore:
Timestamp:
Nov 8, 2010 3:58:57 AM (13 years ago)
Author:
Csaba Osztrogonác
Message:

2010-11-08 Csaba Osztrogonac <Csaba Osztrogonác>

Unreviewed, rolling out r71466.
http://trac.webkit.org/changeset/71466
https://bugs.webkit.org/show_bug.cgi?id=48865

It broke layout tests on GTK bots.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_init): (webkit_web_view_set_group_name):

2010-11-08 Csaba Osztrogonac <Csaba Osztrogonác>

Unreviewed, rolling out r71466.
http://trac.webkit.org/changeset/71466
https://bugs.webkit.org/show_bug.cgi?id=48865

It broke layout tests on GTK bots.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/gtk/ChangeLog

    r71499 r71510  
     12010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
     2
     3        Unreviewed, rolling out r71466.
     4        http://trac.webkit.org/changeset/71466
     5        https://bugs.webkit.org/show_bug.cgi?id=48865
     6
     7        It broke layout tests on GTK bots.
     8
     9        * WebCoreSupport/ChromeClientGtk.cpp:
     10        (WebKit::ChromeClient::closeWindowSoon):
     11        * webkit/webkitprivate.h:
     12        * webkit/webkitwebview.cpp:
     13        (webkit_web_view_init):
     14        (webkit_web_view_set_group_name):
     15
    1162010-11-07  Adam Barth  <abarth@webkit.org>
    217
  • trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

    r71466 r71510  
    256256    if (isHandled)
    257257        return;
     258
     259    // FIXME: should we clear the frame group name here explicitly? Mac does it.
     260    // But this gets cleared in Page's destructor anyway.
     261    // webkit_web_view_set_group_name(m_webView, "");
    258262}
    259263
  • trunk/WebKit/gtk/webkit/webkitprivate.h

    r71466 r71510  
    389389
    390390    WEBKIT_API void
     391    webkit_web_view_set_group_name(WebKitWebView* web_view, const gchar* group_name);
     392
     393    WEBKIT_API void
    391394    webkit_web_settings_add_extra_plugin_directory (WebKitWebView *web_view, const gchar* directory);
    392395
  • trunk/WebKit/gtk/webkit/webkitwebview.cpp

    r71499 r71510  
    32493249    priv->corePage = new Page(pageClients);
    32503250
    3251     // Pages within a same session need to be linked together otherwise some functionalities such
    3252     // as visited link coloration (across pages) and changing popup window location will not work.
    3253     // To keep the default behavior simple (and because no PageGroup API exist in WebKitGTK at the
    3254     // time of writing this comment), we simply set all the pages to the same group.
    3255     priv->corePage->setGroupName("WebKitGTK");
    3256 
    32573251    // We also add a simple wrapper class to provide the public
    32583252    // interface for the Web Inspector.
     
    45184512    gboolean handled;
    45194513    g_signal_emit(webView, webkit_web_view_signals[MOVE_CURSOR], 0, step, count, &handled);
     4514}
     4515
     4516void webkit_web_view_set_group_name(WebKitWebView* webView, const gchar* groupName)
     4517{
     4518    g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
     4519
     4520    WebKitWebViewPrivate* priv = webView->priv;
     4521
     4522    if (!priv->corePage)
     4523        return;
     4524
     4525    priv->corePage->setGroupName(String::fromUTF8(groupName));
    45204526}
    45214527
  • trunk/WebKitTools/ChangeLog

    r71509 r71510  
     12010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
     2
     3        Unreviewed, rolling out r71466.
     4        http://trac.webkit.org/changeset/71466
     5        https://bugs.webkit.org/show_bug.cgi?id=48865
     6
     7        It broke layout tests on GTK bots.
     8
     9        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     10        (createWebView):
     11
    1122010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
    213
  • trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r71466 r71510  
    7070extern gchar* webkit_web_frame_get_response_mime_type(WebKitWebFrame* frame);
    7171extern void webkit_web_frame_clear_main_frame_name(WebKitWebFrame* frame);
     72extern void webkit_web_view_set_group_name(WebKitWebView* view, const gchar* groupName);
    7273extern void webkit_reset_origin_access_white_lists();
    7374}
     
    10001001    DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled(true);
    10011002
     1003    // From bug 11756: Use a frame group name for all WebViews created by
     1004    // DumpRenderTree to allow testing of cross-page frame lookup.
     1005    webkit_web_view_set_group_name(view, "org.webkit.gtk.DumpRenderTree");
     1006
    10021007    g_object_connect(G_OBJECT(view),
    10031008                     "signal::load-started", webViewLoadStarted, 0,
Note: See TracChangeset for help on using the changeset viewer.