Changeset 71587 in webkit


Ignore:
Timestamp:
Nov 8, 2010 5:05:37 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2010-11-08 Pierre-Antoine LaFayette <​pierre.lafayette@gmail.com>

Reviewed by Darin Fisher.

[chromium] Adding hasUserGesture flag to the ResourceRequest
​https://bugs.webkit.org/show_bug.cgi?id=37057

This flag is to be used on the browser side to indicate when a
download has been user initiated.

No new tests. This change will be tested through a browser UI test.

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::hasUserGesture): (WebCore::ResourceRequest::setHasUserGesture):

2010-11-08 Pierre-Antoine LaFayette <​pierre.lafayette@gmail.com>

Reviewed by Darin Fisher.

[chromium] Adding hasUserGesture flag to the ResourceRequest
​https://bugs.webkit.org/show_bug.cgi?id=37057

This flag is to be used on the browser side to indicate when a
download has been user initiated.

  • public/WebURLRequest.h:
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::hasUserGesture): (WebKit::WebURLRequest::setHasUserGesture):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r71586 r71587  
     12010-11-08  Pierre-Antoine LaFayette  <pierre.lafayette@gmail.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Adding hasUserGesture flag to the ResourceRequest
     6        https://bugs.webkit.org/show_bug.cgi?id=37057
     7
     8        This flag is to be used on the browser side to indicate when a
     9        download has been user initiated.
     10
     11        No new tests. This change will be tested through a browser UI test.
     12
     13        * platform/network/chromium/ResourceRequest.h:
     14        (WebCore::ResourceRequest::ResourceRequest):
     15        (WebCore::ResourceRequest::hasUserGesture):
     16        (WebCore::ResourceRequest::setHasUserGesture):
     17
    1182010-11-08  Chris Rogers  <crogers@google.com>
    219

  • trunk/WebCore/platform/network/chromium/ResourceRequest.cpp

    r68762 r71587  
    4343    data->m_requestorProcessID = m_requestorProcessID;
    4444    data->m_appCacheHostID = m_appCacheHostID;
     45    data->m_hasUserGesture = m_hasUserGesture;
    4546    return data;
    4647}
    … …  
    5152    m_requestorProcessID = data->m_requestorProcessID;
    5253    m_appCacheHostID = data->m_appCacheHostID;
     54    m_hasUserGesture = data->m_hasUserGesture;
    5355}
    5456

  • trunk/WebCore/platform/network/chromium/ResourceRequest.h

    r68762 r71587  
    4242            , m_requestorProcessID(0)
    4343            , m_appCacheHostID(0)
     44            , m_hasUserGesture(false)
    4445        {
    4546        }
    … …  
    5051            , m_requestorProcessID(0)
    5152            , m_appCacheHostID(0)
     53            , m_hasUserGesture(false)
    5254        {
    5355        }
    … …  
    5860            , m_requestorProcessID(0)
    5961            , m_appCacheHostID(0)
     62            , m_hasUserGesture(false)
    6063        {
    6164            setHTTPReferrer(referrer);
    … …  
    6770            , m_requestorProcessID(0)
    6871            , m_appCacheHostID(0)
     72            , m_hasUserGesture(false)
    6973        {
    7074        }
    … …  
    8589        void setAppCacheHostID(int id) { m_appCacheHostID = id; }
    8690
     91        // True if request was user initiated.
     92        bool hasUserGesture() const { return m_hasUserGesture; }
     93        void setHasUserGesture(bool hasUserGesture) { m_hasUserGesture = hasUserGesture; }
     94
    8795    private:
    8896        friend class ResourceRequestBase;
    … …  
    97105        int m_requestorProcessID;
    98106        int m_appCacheHostID;
     107        bool m_hasUserGesture;
    99108    };
    100109
    … …  
    103112        int m_requestorProcessID;
    104113        int m_appCacheHostID;
     114        bool m_hasUserGesture;
    105115    };
    106116

  • trunk/WebKit/chromium/ChangeLog

    r71541 r71587  
     12010-11-08  Pierre-Antoine LaFayette  <pierre.lafayette@gmail.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Adding hasUserGesture flag to the ResourceRequest
     6        https://bugs.webkit.org/show_bug.cgi?id=37057
     7
     8        This flag is to be used on the browser side to indicate when a
     9        download has been user initiated.
     10
     11        * public/WebURLRequest.h:
     12        * src/WebURLRequest.cpp:
     13        (WebKit::WebURLRequest::hasUserGesture):
     14        (WebKit::WebURLRequest::setHasUserGesture):
     15
    1162010-11-08  Alexey Proskuryakov  <ap@apple.com>
    217

  • trunk/WebKit/chromium/public/WebURLRequest.h

    r71440 r71587  
    141141    WEBKIT_API void setTargetType(TargetType);
    142142
     143    // True if the request was user initiated.
     144    WEBKIT_API bool hasUserGesture() const;
     145    WEBKIT_API void setHasUserGesture(bool);
     146
    143147    // A consumer controlled value intended to be used to identify the
    144148    // requestor.

  • trunk/WebKit/chromium/src/WebURLRequest.cpp

    r68781 r71587  
    222222}
    223223
     224bool WebURLRequest::hasUserGesture() const
     225{
     226    return m_private->m_resourceRequest->hasUserGesture();
     227}
     228
     229void WebURLRequest::setHasUserGesture(bool hasUserGesture)
     230{
     231    m_private->m_resourceRequest->setHasUserGesture(hasUserGesture);
     232}
     233
    224234void WebURLRequest::setTargetType(TargetType targetType)
    225235{
Note: See TracChangeset for help on using the changeset viewer.