Changeset 71936 in webkit

Timestamp:

Nov 12, 2010 12:23:34 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-11-12 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path::addArc() does not set right angle direction on full arcs
​https://bugs.webkit.org/show_bug.cgi?id=49138

New test for nonzero winding rule correctness for full arc paths.

• fast/canvas/canvas-arc-360-winding-expected.txt: Added.
• fast/canvas/canvas-arc-360-winding.html: Added.
• fast/canvas/script-tests/canvas-arc-360-winding.js: Added.

2010-11-12 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path::addArc() does not set right angle direction on full arcs
​https://bugs.webkit.org/show_bug.cgi?id=49138

Ensure correctness of nonzero winding rule for full arc paths.
Invert the sign of the span if the direction is counterclockwise.

Test: fast/canvas/canvas-arc-360-winding.html

• platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/canvas-arc-360-winding-expected.txt (added)
• LayoutTests/fast/canvas/canvas-arc-360-winding.html (added)
• LayoutTests/fast/canvas/script-tests/canvas-arc-360-winding.js (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/qt/PathQt.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-12  Helder Correia  <helder@sencha.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] Path::addArc() does not set right angle direction on full arcs
+        https://bugs.webkit.org/show_bug.cgi?id=49138
+
+        New test for nonzero winding rule correctness for full arc paths.
+
+        * fast/canvas/canvas-arc-360-winding-expected.txt: Added.
+        * fast/canvas/canvas-arc-360-winding.html: Added.
+        * fast/canvas/script-tests/canvas-arc-360-winding.js: Added.
+
 2010-11-05  Dimitri Glazkov  <dglazkov@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-12  Helder Correia  <helder@sencha.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] Path::addArc() does not set right angle direction on full arcs
+        https://bugs.webkit.org/show_bug.cgi?id=49138
+
+        Ensure correctness of nonzero winding rule for full arc paths.
+        Invert the sign of the span if the direction is counterclockwise.
+
+        Test: fast/canvas/canvas-arc-360-winding.html
+
+        * platform/graphics/qt/PathQt.cpp:
+        (WebCore::Path::addArc):
+
 2010-11-05  Dimitri Glazkov  <dglazkov@chromium.org>
 

trunk/WebCore/platform/graphics/qt/PathQt.cpp

@@ -291 +291 @@
     double height = radius*2;
 
-    if ((!anticlockwise && (ea - sa >= 360)) || (anticlockwise && (sa - ea >= 360)))
+    if ((!anticlockwise && (ea - sa >= 360)) || (anticlockwise && (sa - ea >= 360))) {
         // If the anticlockwise argument is false and endAngle-startAngle is equal to or greater than 2*PI, or, if the
         // anticlockwise argument is true and startAngle-endAngle is equal to or greater than 2*PI, then the arc is the whole
         // circumference of this circle.
         span = 360;
-    else {
+
+        if (anticlockwise)
+            span = -span;
+    } else {
         if (!anticlockwise && (ea < sa))
             span += 360;