Changeset 72146 in webkit
- Timestamp:
- Nov 16, 2010 3:54:36 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKit/mac/ChangeLog
r72141 r72146 1 2010-11-16 Stephanie Lewis <slewis@apple.com> 2 3 Reviewed by Geoff Garen. 4 5 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests 6 7 Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for 8 every WebView, and the WebKit API doesn't support that ownership model. 9 10 * WebView/WebDeviceOrientationProviderMock.h: 11 * WebView/WebDeviceOrientationProviderMock.mm: 12 (+[WebDeviceOrientationProviderMock shared]): 13 1 14 2010-11-16 Dave Hyatt <hyatt@apple.com> 2 15 -
trunk/WebKit/mac/WebView/WebDeviceOrientationProviderMock.h
r66685 r72146 33 33 } 34 34 35 + (WebDeviceOrientationProviderMock *)shared; 36 35 37 - (id)init; 36 38 - (void)setOrientation:(WebDeviceOrientation*)orientation; -
trunk/WebKit/mac/WebView/WebDeviceOrientationProviderMock.mm
r66935 r72146 79 79 @implementation WebDeviceOrientationProviderMock 80 80 81 + (WebDeviceOrientationProviderMock *)shared 82 { 83 static WebDeviceOrientationProviderMock *provider = [[WebDeviceOrientationProviderMock alloc] init]; 84 return provider; 85 } 86 81 87 - (id)init 82 88 { -
trunk/WebKitTools/ChangeLog
r72143 r72146 1 2010-11-16 Stephanie Lewis <slewis@apple.com> 2 3 Reviewed by Geoff Garen. 4 5 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests 6 7 Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 8 for every WebView, and the WebKit API doesn't support that ownership model. 9 10 I also fixed a leak in setMockDeviceOrientation by adding a missing release. 11 12 * DumpRenderTree/mac/DumpRenderTree.mm: 13 (createWebViewAndOffscreenWindow): 14 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15 (LayoutTestController::setMockDeviceOrientation): 16 1 17 2010-11-16 Dirk Pranke <dpranke@chromium.org> 2 18 -
trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm
r71560 r72146 296 296 [webView setResourceLoadDelegate:resourceLoadDelegate]; 297 297 [webView _setGeolocationProvider:[MockGeolocationProvider shared]]; 298 [webView _setDeviceOrientationProvider:[ [WebDeviceOrientationProviderMock alloc] init]];298 [webView _setDeviceOrientationProvider:[WebDeviceOrientationProviderMock shared]]; 299 299 300 300 // Register the same schemes that Safari does -
trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
r70975 r72146 349 349 WebDeviceOrientation* orientation = [[WebDeviceOrientation alloc] initWithCanProvideAlpha:canProvideAlpha alpha:alpha canProvideBeta:canProvideBeta beta:beta canProvideGamma:canProvideGamma gamma:gamma]; 350 350 [mockProvider setOrientation:orientation]; 351 [orientation release]; 351 352 } 352 353
Note: See TracChangeset
for help on using the changeset viewer.