Changeset 72631 in webkit

Timestamp:

Nov 23, 2010 2:54:45 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-11-23 Shimeng (Simon) Wang <​swang@google.com>

Reviewed by Steve Block.

Use platform bridge to set scroll position.
​https://bugs.webkit.org/show_bug.cgi?id=49550

Refactoring only. Existing tests shall suffice.

• platform/android/PlatformBridge.h:
• platform/android/ScrollViewAndroid.cpp: (WebCore::ScrollView::platformSetScrollPosition):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/android/PlatformBridge.h (modified) (2 diffs)
• platform/android/ScrollViewAndroid.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-23  Shimeng (Simon) Wang  <swang@google.com>
+
+        Reviewed by Steve Block.
+
+        Use platform bridge to set scroll position.
+        https://bugs.webkit.org/show_bug.cgi?id=49550
+
+        Refactoring only.  Existing tests shall suffice.
+
+        * platform/android/PlatformBridge.h:
+        * platform/android/ScrollViewAndroid.cpp:
+        (WebCore::ScrollView::platformSetScrollPosition):
+
 2010-11-23  Andreas Kling  <kling@webkit.org>
 

trunk/WebCore/platform/android/PlatformBridge.h

@@ -82 +82 @@
 namespace WebCore {
 
+class ScrollView;
 class Widget;
 
@@ -105 +106 @@
     // Plugin
     static NPObject* pluginScriptableObject(Widget*);
+
+    static void setScrollPosition(ScrollView*, int x, int y);
+
     // Language
     static String computeDefaultLanguage();

trunk/WebCore/platform/android/ScrollViewAndroid.cpp

@@ -71 +71 @@
     if (parent()) // don't attempt to scroll subframes; they're fully visible
         return;
-    android::WebViewCore::getWebViewCore(this)->scrollTo(pt.x(), pt.y());
+    PlatformBridge::setScrollPosition(this, pt.x(), pt.y());
 }